LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Matthew Garrett <mjg59@coreos.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	kristen@linux.intel.com
Subject: Re: [PATCH 3/3] libata: Change medium_power LPM policy to match Intel recommendations
Date: Wed, 22 Apr 2015 10:51:57 -0400	[thread overview]
Message-ID: <20150422145157.GB10592@htj.duckdns.org> (raw)
In-Reply-To: <1429370796-5881-4-git-send-email-mjg59@coreos.com>

On Sat, Apr 18, 2015 at 08:26:36AM -0700, Matthew Garrett wrote:
> Intel publish a document on designing energy efficient SATA devices at
> http://www.intel.com/content/dam/doc/reference-guide/sata-devices-implementation-recommendations.pdf
> which recommends that ALPE be set, ASPE be cleared and that DIPM be enabled
> on the device. Right now we have no policy that matches that - medium_power
> does not enable DIPM and min_power sets ASPE. Change medium_power to
> implement these recommendations, with the addition of devslp state being
> inherited from the initial configuration. With luck this will provide
> reasonable power savings without causing the device breakages we
> occasionally see with the min_power policy.

Can we add comment explaining what med_power implements and link to
the above?

Thanks.

-- 
tejun

      reply	other threads:[~2015-04-22 14:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-18 15:26 Rework AHCI LPM handling a little Matthew Garrett
2015-04-18 15:26 ` [PATCH 1/3] libata: Stash initial power management configuration Matthew Garrett
2015-04-21 21:26   ` Tejun Heo
2015-04-18 15:26 ` [PATCH 2/3] libata: Add firmware_default LPM policy Matthew Garrett
2015-04-22 14:48   ` Tejun Heo
2015-05-11 20:24     ` Matthew Garrett
2015-05-11 20:28       ` Tejun Heo
2015-05-11 20:34         ` Matthew Garrett
2015-05-11 20:43           ` Tejun Heo
2015-04-18 15:26 ` [PATCH 3/3] libata: Change medium_power LPM policy to match Intel recommendations Matthew Garrett
2015-04-22 14:51   ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150422145157.GB10592@htj.duckdns.org \
    --to=tj@kernel.org \
    --cc=kristen@linux.intel.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@coreos.com \
    --subject='Re: [PATCH 3/3] libata: Change medium_power LPM policy to match Intel recommendations' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).