From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752220AbbEHMvc (ORCPT ); Fri, 8 May 2015 08:51:32 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:35887 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbbEHMv3 (ORCPT ); Fri, 8 May 2015 08:51:29 -0400 Date: Fri, 8 May 2015 14:51:02 +0200 From: Sascha Hauer To: Matthias Brugger Cc: "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , linux-mediatek@lists.infradead.org, "linux-kernel@vger.kernel.org" , =Sascha Hauer , Kevin Hilman Subject: Re: [PATCH 2/4] soc: Mediatek: Add SCPSYS power domain driver Message-ID: <20150508125102.GE6325@pengutronix.de> References: <1426002063-25713-1-git-send-email-s.hauer@pengutronix.de> <1426002063-25713-3-git-send-email-s.hauer@pengutronix.de> <20150508121944.GD6325@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 14:49:24 up 53 days, 41 min, 78 users, load average: 0.13, 0.16, 0.14 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 08, 2015 at 02:28:37PM +0200, Matthias Brugger wrote: > 2015-05-08 14:19 GMT+02:00 Sascha Hauer : > > On Fri, May 08, 2015 at 02:16:06PM +0200, Matthias Brugger wrote: > >> 2015-03-10 16:41 GMT+01:00 Sascha Hauer : > >> > +static int scpsys_power_on(struct generic_pm_domain *genpd) > >> > +{ > >> > + struct scp_domain *scpd = container_of(genpd, struct scp_domain, pmd); > >> > + struct scp *scp = scpd->scp; > >> > + struct scp_domain_data *data = scpd->data; > >> > + unsigned long expired; > >> > + void __iomem *ctl_addr = scpd->scp->base + data->ctl_offs; > >> > + u32 sram_pdn_ack = data->sram_pdn_ack_bits; > >> > + u32 val; > >> > + int ret; > >> > + > >> > + val = readl(ctl_addr); > >> > + val |= PWR_ON_BIT; > >> > + writel(val, ctl_addr); > >> > + val |= PWR_ON_2ND_BIT; > >> > + writel(val, ctl_addr); > >> > + > >> > + /* wait until PWR_ACK = 1 */ > >> > + expired = jiffies + HZ; > >> > + while (!(readl(scp->base + SPM_PWR_STATUS) & data->sta_mask) || > >> > + !(readl(scp->base + SPM_PWR_STATUS_2ND) & data->sta_mask)) { > >> > + cpu_relax(); > >> > + if (time_after(jiffies, expired)) { > >> > + ret = -EIO; > >> > + goto out; > >> > + } > >> > + } > >> > + > >> > + val &= ~PWR_CLK_DIS_BIT; > >> > + writel(val, ctl_addr); > >> > + > >> > + val &= ~PWR_ISO_BIT; > >> > + writel(val, ctl_addr); > >> > + > >> > + val |= PWR_RST_B_BIT; > >> > + writel(val, ctl_addr); > >> > + > >> > + val &= ~data->sram_pdn_bits; > >> > + writel(val, ctl_addr); > >> > + > >> > + /* wait until SRAM_PDN_ACK all 0 */ > >> > + expired = jiffies + HZ; > >> > + while (sram_pdn_ack && (readl(ctl_addr) & sram_pdn_ack)) { > >> > >> I think "sram_pdn_ack &&" was added accidently here. It is always > >> bigger then zero. > > > > Nope, it's zero for MT8173_POWER_DOMAIN_MFG_ASYNC. > > In probe you turn on all power domains defined in scp_domain_data[]. > So all but MT8173_POWER_DOMAIN_MFG_ASYNC will fail. > Does this make sense? What makes you think that enabling the domains will fail? That doesn't happen. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |