LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Theodore Ts'o" <tytso@mit.edu>
To: Oscar Forner Martinez <oscar.forner.martinez@gmail.com>
Cc: linux-kernel@vger.kernel.org, adilger.kernel@dilger.ca,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Fixed two coding style errors, spaces required around =
Date: Tue, 12 May 2015 13:54:06 -0400	[thread overview]
Message-ID: <20150512175406.GA18150@thunk.org> (raw)
In-Reply-To: <1423053226-10210-1-git-send-email-oscar.forner.martinez@gmail.com>

On Wed, Feb 04, 2015 at 12:33:46PM +0000, Oscar Forner Martinez wrote:
> Two lines with assignation without spaces around the =
> 
> Signed-off-by: Oscar Forner Martinez <oscar.forner.martinez@gmail.com>

NACK, we don't generally take code cleanup patches unless it's part of
changes in that part of the code.  Otherwise, code cleanup patches
break other people's pending patches which are waiting code review;
and so "code cleanup" patches end up adding negative, not positive,
value.

Regards,

					- Ted

      reply	other threads:[~2015-05-12 17:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-04 12:33 Oscar Forner Martinez
2015-05-12 17:54 ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150512175406.GA18150@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oscar.forner.martinez@gmail.com \
    --subject='Re: [PATCH] ext4: Fixed two coding style errors, spaces required around =' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).