LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, Will Deacon <will.deacon@arm.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Markus Metzger <markus.t.metzger@intel.com>
Subject: Re: [PATCH v1 1/4] perf: Allow suppressing AUX records
Date: Wed, 15 Nov 2017 13:00:22 +0100	[thread overview]
Message-ID: <20171115120022.o7hmfdb7vpeikvjl@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20171114123024.11517-2-alexander.shishkin@linux.intel.com>

On Tue, Nov 14, 2017 at 02:30:21PM +0200, Alexander Shishkin wrote:
> It has been pointed out to me many times that it is useful to be able
> to switch off AUX records to save the bandwidth for records that actually
> matter, for example, in AUX overwrite mode.
> 
> The usefulness of PERF_RECORD_AUX is in some of its flags, like the
> TRUNCATED flag that tells the decoder where exactly gaps in the trace are.
> The OVERWRITE flag, on the other hand will be set on every single record
> in overwrite mode. However, a PERF_RECORD_AUX[flags=OVERWRITE] is
> generated on every target task's sched_out, which over time adds up to
> a lot of useless information.
> 
> This patch adds an attribute bit that enables suppressing such records.

What this fails to explain is why a separate suppression flag makes
sense. Why not suppress the thing on overwrite mode and be done with it?

> +		if (!handle->event->attr.suppress_aux ||
> +		    (handle->aux_flags & ~(u64)SUPPRESSABLE_FLAGS))
> +			perf_event_aux_event(handle->event, aux_head, size,
> +					     handle->aux_flags);

That wants { }

  reply	other threads:[~2017-11-15 12:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-14 12:30 [PATCH v1 0/4] perf: Allow suppressing useless " Alexander Shishkin
2017-11-14 12:30 ` [PATCH v1 1/4] perf: Allow suppressing " Alexander Shishkin
2017-11-15 12:00   ` Peter Zijlstra [this message]
2018-01-15 15:00     ` [PATCH] " Alexander Shishkin
2018-03-29 11:54       ` Peter Zijlstra
2018-03-31  9:35         ` Ingo Molnar
2018-04-03 17:32           ` Will Deacon
2018-04-04 14:53             ` [PATCH v2] perf: Suppress AUX/OVERWRITE records Alexander Shishkin
2018-05-04 12:09               ` Alexander Shishkin
2018-05-04 15:35                 ` Arnaldo Carvalho de Melo
2018-05-04 15:36                   ` Arnaldo Carvalho de Melo
2018-09-25  9:27               ` [tip:perf/core] " tip-bot for Alexander Shishkin
2017-11-14 12:30 ` [PATCH v1 2/4] tools, perf_event.h: Synchronize Alexander Shishkin
2017-11-14 12:30 ` [PATCH v1 3/4] perf tools: Add 'suppress_aux' attribute bit definition and fallback Alexander Shishkin
2017-11-14 12:30 ` [PATCH v1 4/4] perf intel-pt, intel-bts: Suppress useless AUX records by default Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171115120022.o7hmfdb7vpeikvjl@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markus.t.metzger@intel.com \
    --cc=mingo@redhat.com \
    --cc=will.deacon@arm.com \
    --subject='Re: [PATCH v1 1/4] perf: Allow suppressing AUX records' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).