LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de> To: LKML <linux-kernel@vger.kernel.org> Cc: Linus Torvalds <torvalds@linuxfoundation.org>, Prarit Bhargava <prarit@redhat.com>, Mark Salyzyn <salyzyn@android.com>, Petr Mladek <pmladek@suse.com>, Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>, Peter Zijlstra <peterz@infradead.org>, Andrew Morton <akpm@linux-foundation.org>, Sergey Senozhatsky <sergey.senozhatsky@gmail.com>, Steven Rostedt <rostedt@goodmis.org>, Joe Perches <joe@perches.com>, Linus Torvalds <torvalds@linux-foundation.org> Subject: [RFC patch 5/7] crash: Add VMCOREINFO_FIELD_AND_OFFSET() Date: Wed, 15 Nov 2017 19:15:36 +0100 [thread overview] Message-ID: <20171115182657.542096222@linutronix.de> (raw) In-Reply-To: 20171115181531.322572387@linutronix.de [-- Attachment #1: crash--Add-VMCOREINFO_FIELD_ANDOFFSET--.patch --] [-- Type: text/plain, Size: 1353 bytes --] Changing the time stamp storage in the printk ringbuffer entries would break existing tools which rely on the availability of the 'ts_nsec' field in vmcore info. Provide a new macro which allows to store the offset of a member of struct printk_log with a different name. This allows to change the underlying storage and without breaking tools. Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- include/linux/crash_core.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/include/linux/crash_core.h +++ b/include/linux/crash_core.h @@ -48,9 +48,11 @@ phys_addr_t paddr_vmcoreinfo_note(void); #define VMCOREINFO_STRUCT_SIZE(name) \ vmcoreinfo_append_str("SIZE(%s)=%lu\n", #name, \ (unsigned long)sizeof(struct name)) -#define VMCOREINFO_OFFSET(name, field) \ - vmcoreinfo_append_str("OFFSET(%s.%s)=%lu\n", #name, #field, \ +#define VMCOREINFO_FIELD_AND_OFFSET(name, fieldname, field) \ + vmcoreinfo_append_str("OFFSET(%s.%s)=%lu\n", #name, #fieldname, \ (unsigned long)offsetof(struct name, field)) +#define VMCOREINFO_OFFSET(name, field) \ + VMCOREINFO_FIELD_AND_OFFSET(name, field, field) #define VMCOREINFO_LENGTH(name, value) \ vmcoreinfo_append_str("LENGTH(%s)=%lu\n", #name, (unsigned long)value) #define VMCOREINFO_NUMBER(name) \
next prev parent reply other threads:[~2017-11-15 18:29 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-11-15 18:15 [RFC patch 0/7] printk: Switch to CLOCK_MONOTONIC and store extra time stamps Thomas Gleixner 2017-11-15 18:15 ` [RFC patch 1/7] timekeeping: Do not unconditionally suspend NMI safe timekeepers Thomas Gleixner 2017-11-15 18:15 ` [RFC patch 2/7] x86/tsc: Set clocksource CLOCK_SOURCE_SUSPEND_ACCESS_OK Thomas Gleixner 2017-11-15 18:15 ` [RFC patch 3/7] printk: Use clock MONOTONIC for timestamps Thomas Gleixner 2017-11-16 7:58 ` Sergey Senozhatsky 2017-11-15 18:15 ` [RFC patch 4/7] timekeeping: Add NMI safe accessor to mono/boot/real clocks Thomas Gleixner 2017-11-17 23:00 ` Steven Rostedt 2017-11-17 23:12 ` Linus Torvalds 2017-11-17 23:43 ` Thomas Gleixner 2017-11-15 18:15 ` Thomas Gleixner [this message] 2017-11-23 12:46 ` [RFC patch 5/7] crash: Add VMCOREINFO_FIELD_AND_OFFSET() Petr Mladek 2017-11-15 18:15 ` [RFC patch 6/7] printk: Store mono/boot/real time timestamps Thomas Gleixner 2017-11-23 13:36 ` Petr Mladek 2017-11-15 18:15 ` [RFC patch 7/7] timekeeping: Hack to use fine grained timestamps during boot Thomas Gleixner 2017-11-23 12:58 ` Petr Mladek 2017-11-28 18:43 ` Prarit Bhargava 2017-11-28 18:47 ` Thomas Gleixner 2017-12-08 11:23 ` Petr Mladek 2017-12-08 19:51 ` Thomas Gleixner 2017-11-28 19:10 ` Mark Salyzyn 2017-11-28 19:45 ` Steven Rostedt 2017-11-28 20:29 ` Mark Salyzyn 2017-11-28 20:38 ` Peter Zijlstra
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20171115182657.542096222@linutronix.de \ --to=tglx@linutronix.de \ --cc=akpm@linux-foundation.org \ --cc=hpa@zytor.com \ --cc=joe@perches.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@kernel.org \ --cc=peterz@infradead.org \ --cc=pmladek@suse.com \ --cc=prarit@redhat.com \ --cc=rostedt@goodmis.org \ --cc=salyzyn@android.com \ --cc=sergey.senozhatsky@gmail.com \ --cc=torvalds@linux-foundation.org \ --cc=torvalds@linuxfoundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).