From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162401AbdKRBiI (ORCPT ); Fri, 17 Nov 2017 20:38:08 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:38218 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162380AbdKRBiA (ORCPT ); Fri, 17 Nov 2017 20:38:00 -0500 Date: Sat, 18 Nov 2017 10:37:54 +0900 (KST) Message-Id: <20171118.103754.1194700313250064153.davem@davemloft.net> To: gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, andreas@kemnade.info, johan@kernel.org, linux-kernel@vger.kernel.org, pombredanne@nexb.com, linux-usb@vger.kernel.org Subject: Re: [PATCH] net: usb: hso.c: remove unneeded DRIVER_LICENSE #define From: David Miller In-Reply-To: <20171117141939.GD17880@kroah.com> References: <20171117141939.GD17880@kroah.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 17 Nov 2017 17:37:59 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman Date: Fri, 17 Nov 2017 15:19:39 +0100 > There is no need to #define the license of the driver, just put it in > the MODULE_LICENSE() line directly as a text string. > > This allows tools that check that the module license matches the source > code license to work properly, as there is no need to unwind the > unneeded dereference. > > Cc: "David S. Miller" > Cc: Andreas Kemnade > Cc: Johan Hovold > Reported-by: Philippe Ombredanne > Signed-off-by: Greg Kroah-Hartman Applied.