From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752691AbdKWMaH (ORCPT ); Thu, 23 Nov 2017 07:30:07 -0500 Received: from mga05.intel.com ([192.55.52.43]:43736 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751678AbdKWMaF (ORCPT ); Thu, 23 Nov 2017 07:30:05 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,441,1505804400"; d="scan'208";a="8651053" Date: Thu, 23 Nov 2017 14:29:58 +0200 From: Heikki Krogerus To: sathyanarayanan.kuppuswamy@linux.intel.com Cc: a.zummo@towertech.it, x86@kernel.org, wim@iguana.be, mingo@redhat.com, alexandre.belloni@free-electrons.com, qipeng.zha@intel.com, hpa@zytor.com, dvhart@infradead.org, tglx@linutronix.de, lee.jones@linaro.org, andy@infradead.org, souvik.k.chakravarty@intel.com, linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, sathyaosid@gmail.com Subject: Re: [RFC v8 3/7] platform/x86: intel_pmc_ipc: Use regmap calls for GCR updates Message-ID: <20171123122958.GD17418@kuha.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 29, 2017 at 02:49:56AM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote: > From: Kuppuswamy Sathyanarayanan > > This patch adds support for regmap based implementation for GCR > read/write/update APIs. > > Signed-off-by: Kuppuswamy Sathyanarayanan > --- > drivers/platform/x86/Kconfig | 1 + > drivers/platform/x86/intel_pmc_ipc.c | 122 +++++++++++++---------------------- > 2 files changed, 46 insertions(+), 77 deletions(-) > > Changes since v7: > * Fixed style issues. > > Changes since v6: > * None > > Changes since v5: > * None > > Changes since v4: > * None > > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig > index 80b8795..45f4e79 100644 > --- a/drivers/platform/x86/Kconfig > +++ b/drivers/platform/x86/Kconfig > @@ -1054,6 +1054,7 @@ config PVPANIC > config INTEL_PMC_IPC > tristate "Intel PMC IPC Driver" > depends on ACPI > + select REGMAP_MMIO > ---help--- > This driver provides support for PMC control on some Intel platforms. > The PMC is an ARC processor which defines IPC commands for communication > diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c > index e36144c..df6af1f 100644 > --- a/drivers/platform/x86/intel_pmc_ipc.c > +++ b/drivers/platform/x86/intel_pmc_ipc.c > @@ -35,6 +35,8 @@ > #include > #include > #include > +#include You already included that in the previous patch. Thanks, -- heikki