LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Guenter Roeck <groeck@google.com>
Cc: Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
Liam Girdwood <lgirdwood@gmail.com>,
perex@perex.cz, Alex Deucher <Alexander.Deucher@amd.com>,
Akshu.Agrawal@amd.com, Guenter Roeck <linux@roeck-us.net>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dominik Behr <dbehr@chromium.org>,
Daniel Kurtz <djkurtz@chromium.org>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH] ASoC: amd: added error checks in dma driver
Date: Thu, 23 Nov 2017 17:29:04 +0000 [thread overview]
Message-ID: <20171123172904.4akrfhlonlwkmgs6@sirena.org.uk> (raw)
In-Reply-To: <CABXOdTezJbmEU=Oa+G1NN+WHoZqJERH8DAapJqgbPXkLnyweLw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
On Thu, Nov 23, 2017 at 08:59:43AM -0800, Guenter Roeck wrote:
> On Thu, Nov 23, 2017 at 8:30 AM, Vijendar Mukunda
> <Vijendar.Mukunda@amd.com> wrote:
> > added error checks in acp dma driver
> > Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> > Signed-off-by: Akshu Agrawal <Akshu.Agrawal@amd.com>
> > Signed-off-by: Guenter Roeck <groeck@chromium.org>
> This is inappropriate.
Specifically: if Guenter wasn't involved in writing or forwarding the
patch he shouldn't have a signoff in there, and if you're the one
sending the mail you should be the last person in the chain of signoffs.
Please see SubmittingPatches for details of what a signoff means and why
they're important.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2017-11-23 17:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 16:30 [PATCH] ASoC: amd: added error checks in dma driver Vijendar Mukunda
2017-11-23 16:59 ` Guenter Roeck
2017-11-23 17:29 ` Mark Brown [this message]
2017-11-24 11:07 ` Mukunda,Vijendar
2017-11-24 8:11 ` Guenter Roeck
2017-11-24 14:19 ` Mukunda,Vijendar
2017-11-28 4:43 Vijendar Mukunda
2017-11-28 11:52 ` Mark Brown
2017-11-30 5:29 ` Mukunda,Vijendar
2017-12-04 15:16 Vijendar Mukunda
2017-12-04 17:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123172904.4akrfhlonlwkmgs6@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Akshu.Agrawal@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=dbehr@chromium.org \
--cc=djkurtz@chromium.org \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).