LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Reza Arbab <arbab@linux.vnet.ibm.com>
To: Andrea Reale <ar@linux.vnet.ibm.com>
Cc: zhong jiang <zhongjiang@huawei.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	m.bielski@virtualopensystems.com, arunks@qti.qualcomm.com,
	mark.rutland@arm.com, scott.branden@broadcom.com,
	will.deacon@arm.com, qiuxishi@huawei.com,
	catalin.marinas@arm.com, mhocko@suse.com, realean2@ie.ibm.com
Subject: Re: [PATCH v2 4/5] mm: memory_hotplug: Add memory hotremove probe device
Date: Mon, 4 Dec 2017 11:50:41 -0600	[thread overview]
Message-ID: <20171204175040.2vgc6ccdcr5m77hm@arbab-laptop.localdomain> (raw)
In-Reply-To: <20171124142948.GA1966@samekh>

On Fri, Nov 24, 2017 at 02:29:48PM +0000, Andrea Reale wrote:
>But, at least in my understanding, the implementation is not as
>straightfoward as it looks. If I declare a memory node in the fdt, then,
>at boot, the kernel will expect that memory to actually be there to be
>used: this is not true if I want to plug my dimms only later at runtime.
>So I think that declaring the hotpluggable memory in an fdt memory
>node might not feasible without changes.

On the power arch, we do this today using "linux,usable-memory".

memory@10000000000 {
  device_type = "memory";
  reg = <0x100 0x0 0x0 0x80000000>;
  linux,usable-memory = <0x100 0x0 0x0 0x40000000>;
  :
}

The reg range defines the node, but at at boot, memblocks are only 
created for the linux,usable-memory range. The rest can be hotplugged 
later. YMMV, because this depends on your arch's implementation of 
memory_add_physaddr_to_nid().

>One idea could be to add a new property to memory nodes, to specify 
>what memory is potentially hotplugguable.

Somewhat related, there is already a "hotpluggable" property.

memory@10040000000 {
  device_type = "memory";
  reg = <0x100 0x40000000 0x0 0x40000000>;
  hotpluggable;
  :
}

This is subtly different from the earlier example. This memory IS 
present at boot. The hotpluggable property ensures that it resides in 
ZONE_MOVABLE so it can potentially be removed.

-- 
Reza Arbab

  reply	other threads:[~2017-12-04 17:50 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 11:13 [PATCH v2 0/5] Memory hotplug support for arm64 - complete patchset v2 Andrea Reale
2017-11-23 11:13 ` [PATCH v2 1/5] mm: memory_hotplug: Memory hotplug (add) support for arm64 Maciej Bielski
2017-11-24  5:55   ` Arun KS
2017-11-24  9:42     ` Andrea Reale
2017-11-24 10:53       ` Maciej Bielski
2017-11-26  6:58         ` Arun KS
2017-11-27 15:19   ` Robin Murphy
2017-11-27 16:39     ` Maciej Bielski
2017-11-27 17:11       ` Andrea Reale
2017-11-23 11:14 ` [PATCH v2 2/5] mm: memory_hotplug: Remove assumption on memory state before hotremove Andrea Reale
2017-11-23 22:18   ` Rafael J. Wysocki
2017-11-24 14:39   ` Rafael J. Wysocki
2017-11-24 14:49     ` Andrea Reale
2017-11-24 15:43       ` Michal Hocko
2017-11-24 15:54         ` Andrea Reale
2017-11-24 18:17           ` Michal Hocko
2017-11-29  1:20             ` joeyli
2017-11-30  9:47               ` Michal Hocko
2017-11-27 15:20           ` Robin Murphy
2017-11-27 17:44             ` Andrea Reale
2017-11-29  0:49   ` joeyli
2017-11-29  1:52     ` joeyli
2017-12-04 11:28       ` Andrea Reale
2017-12-04 14:05         ` Rafael J. Wysocki
2017-11-23 11:14 ` [PATCH v2 3/5] mm: memory_hotplug: memblock to track partially removed vmemmap mem Andrea Reale
2017-11-27 15:20   ` Robin Murphy
2017-11-27 17:38     ` Andrea Reale
2017-11-30 14:51   ` Michal Hocko
2017-12-04 11:49     ` Andrea Reale
2017-12-04 12:32       ` Michal Hocko
2017-12-04 12:42         ` Andrea Reale
2017-12-04 12:48           ` Michal Hocko
2017-11-23 11:14 ` [PATCH v2 4/5] mm: memory_hotplug: Add memory hotremove probe device Andrea Reale
2017-11-24 10:35   ` zhong jiang
2017-11-24 10:44     ` Andrea Reale
2017-11-24 12:17       ` zhong jiang
2017-11-24 14:29         ` Andrea Reale
2017-12-04 17:50           ` Reza Arbab [this message]
2017-11-27 15:33   ` Robin Murphy
2017-11-27 17:14     ` Andrea Reale
2017-11-30 14:49   ` Michal Hocko
2017-12-04 11:51     ` Andrea Reale
2017-12-04 12:33       ` Michal Hocko
2017-12-04 12:44         ` Andrea Reale
2017-11-23 11:15 ` [PATCH v2 5/5] mm: memory-hotplug: Add memory hot remove support for arm64 Andrea Reale
2017-11-23 16:02 ` [PATCH v2 0/5] Memory hotplug support for arm64 - complete patchset v2 Michal Hocko
2017-11-23 17:33   ` Andrea Reale
2017-11-30 14:57     ` Michal Hocko
2017-12-04 11:34       ` Andrea Reale

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204175040.2vgc6ccdcr5m77hm@arbab-laptop.localdomain \
    --to=arbab@linux.vnet.ibm.com \
    --cc=ar@linux.vnet.ibm.com \
    --cc=arunks@qti.qualcomm.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=m.bielski@virtualopensystems.com \
    --cc=mark.rutland@arm.com \
    --cc=mhocko@suse.com \
    --cc=qiuxishi@huawei.com \
    --cc=realean2@ie.ibm.com \
    --cc=scott.branden@broadcom.com \
    --cc=will.deacon@arm.com \
    --cc=zhongjiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).