From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbdLFP7a (ORCPT ); Wed, 6 Dec 2017 10:59:30 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:44675 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbdLFP70 (ORCPT ); Wed, 6 Dec 2017 10:59:26 -0500 Date: Wed, 6 Dec 2017 16:59:17 +0100 From: Peter Zijlstra To: Hareesh Gundu Cc: Linus Torvalds , Steven Rostedt , jcrouse@codeaurora.org, Mel Gorman , efault@gmx.de, tglx@linutronix.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] lib/plist.c: Export plist_*() APIs Message-ID: <20171206155917.se5mmw2gf5qz4otf@hirez.programming.kicks-ass.net> References: <1512484543-24772-1-git-send-email-hareeshg@codeaurora.org> <20171205144104.egber33dwpc6uo7c@hirez.programming.kicks-ass.net> <12861d19-1579-2f78-7c4c-ac8983b505ae@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12861d19-1579-2f78-7c4c-ac8983b505ae@codeaurora.org> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 06, 2017 at 08:59:27PM +0530, Hareesh Gundu wrote: > > On 12/5/2017 8:11 PM, Peter Zijlstra wrote: > > On Tue, Dec 05, 2017 at 08:05:43PM +0530, Hareesh Gundu wrote: > > > Allow plist_add(), plist_del() and plist_requeue() APIs to > > > be referenced by kernel modules by adding the EXPORT_SYMBOL(). > This change is not for in-tree kernel module. It's for modules built outside > of kernel tree modules. > > Is it really required to show out tree kernel modules ? Typically we don't add EXPORTs for functions not used in in-tree modules.