LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: jan.tuerk@emtrion.com
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"David Airlie" <airlied@linux.ie>,
	"Russell King" <linux@armlinux.org.uk>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Fabio Estevam" <fabio.estevam@nxp.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Kevin Hilman" <khilman@baylibre.com>,
	"Maxime Ripard" <maxime.ripard@free-electrons.com>,
	"Alexandre Belloni" <alexandre.belloni@free-electrons.com>,
	"SZ Lin" <sz.lin@moxa.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series
Date: Thu, 21 Dec 2017 17:19:05 -0600	[thread overview]
Message-ID: <20171221231905.e3fmhhbkzzrha5jg@rob-hp-laptop> (raw)
In-Reply-To: <20171220134710.64479-5-jan.tuerk@emtrion.com>

On Wed, Dec 20, 2017 at 02:47:04PM +0100, jan.tuerk@emtrion.com wrote:
> From: Jan Tuerk <jan.tuerk@emtrion.com>
> 
> This patch adds support for the emtrion GmbH emCON-MX6 modules.
> They are available with imx.6 Solo, Dual-Lite, Dual and Quad
> equipped with Memory from 512MB to 2GB (configured by U-Boot).
> 
> Our default developer-Kit ships with the Avari baseboard and the
> EDT ETM0700G0BDH6 Display (imx6[q|dl]-emcon-avari).
> 
> The devicetree is split into the common part providing all module
> components and the basic support for all SoC versions
> (imx6qdl-emcon.dtsi) and parts which are i.mx6 S|DL and D|Q relevant.
> Finally the support for the avari baseboard in the developer-kit
> configuration is provided by the emcon-avari dts files.
> 
> Signed-off-by: Jan Tuerk <jan.tuerk@emtrion.com>
> ---
> Changes in v2:
>  - Fixed typo (reg_prallel.. --> reg_parallel)
>  - Removed trailing new-line
>  - Fix uppercase addresses as Rob H. noted
>  - Fix warning about lcd@di0 -> rename to disp0
>  - Renamed some nodes regarding Rob H.
> 
>  Documentation/devicetree/bindings/arm/emtrion.txt |  13 +
>  arch/arm/boot/dts/Makefile                        |   2 +
>  arch/arm/boot/dts/imx6dl-emcon-avari.dts          | 233 ++++++
>  arch/arm/boot/dts/imx6dl-emcon.dtsi               |  37 +
>  arch/arm/boot/dts/imx6q-emcon-avari.dts           | 233 ++++++
>  arch/arm/boot/dts/imx6q-emcon.dtsi                |  37 +
>  arch/arm/boot/dts/imx6qdl-emcon.dtsi              | 848 ++++++++++++++++++++++
>  7 files changed, 1403 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/emtrion.txt
>  create mode 100644 arch/arm/boot/dts/imx6dl-emcon-avari.dts
>  create mode 100644 arch/arm/boot/dts/imx6dl-emcon.dtsi
>  create mode 100644 arch/arm/boot/dts/imx6q-emcon-avari.dts
>  create mode 100644 arch/arm/boot/dts/imx6q-emcon.dtsi
>  create mode 100644 arch/arm/boot/dts/imx6qdl-emcon.dtsi

[...]

> +	captouch: touchscreen@38 {
> +		reg = <0x38>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pinctrl_irq_touch2 &pinctrl_emcon_gpio4>;
> +		interrupt-parent = <&gpio6>;
> +		interrupts = <31 IRQ_TYPE_EDGE_FALLING>;
> +		compatible = "edt,edt-ft5406";

Put compatible as the first property.

> +		wake-gpios = <&gpio2 3 GPIO_ACTIVE_HIGH>;
> +		wakeup-source;
> +	};
> +};

[...]

> +&rgb_panel {
> +	compatible = "edt,etm0700g0bdh6";
> +	status = "okay";

Having compatible here is a bit strange and fragile. It's assuming 2 
different panels have the same common properties.


> diff --git a/arch/arm/boot/dts/imx6q-emcon.dtsi b/arch/arm/boot/dts/imx6q-emcon.dtsi
> new file mode 100644
> index 000000000000..64fc0cd74c05
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6q-emcon.dtsi
> @@ -0,0 +1,37 @@
> +/*
> + * Copyright (C) 2017 emtrion GmbH
> + * Author: Jan Tuerk  <jan.tuerk@emtrion.com>
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html

You don't need this if...

> + *
> + * SPDX-License-Identifier: GPL-2.0

You have this.

Also, the rules around this are getting a bit stricter saying the SPDX 
tag should be the first line of the file using a C++ style comment.

> + *
> + */
> +
> +/ {
> +	model = "emtrion SoM emCON-MX6 Dual/Quad";
> +	compatible = "emtrion,emcon-mx6","fsl,imx6q";

Need a space                             ^

> diff --git a/arch/arm/boot/dts/imx6qdl-emcon.dtsi b/arch/arm/boot/dts/imx6qdl-emcon.dtsi
> new file mode 100644
> index 000000000000..f87d8ed6a1b1
> --- /dev/null
> +++ b/arch/arm/boot/dts/imx6qdl-emcon.dtsi
> @@ -0,0 +1,848 @@
> +/*
> + * Copyright (C) 2017 emtrion GmbH
> + * Author: Jan Tuerk  <jan.tuerk@emtrion.com>
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + *
> + * SPDX-License-Identifier: GPL-2.0
> + *
> + */
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pwm/pwm.h>
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> +
> +	model = "emtrion SoM emCON-MX6";
> +	compatible = "emtrion,emcon-mx6","fsl,imx6q", "fsl,imx6dl";

Need a space                             ^

  reply	other threads:[~2017-12-21 23:19 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23 12:55 [PATCH 0/5] Add basic support for emtrion emCON-MX6 modules Jan Tuerk
2017-11-23 12:55 ` [PATCH 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6 Jan Tuerk
2017-11-23 15:08   ` Fabio Estevam
2017-11-23 15:18     ` AW: " Türk, Jan
2017-11-24 14:21       ` Fabio Estevam
2017-11-24 14:59         ` AW: " Türk, Jan
2017-11-26 19:10   ` Rob Herring
2017-11-23 12:55 ` [PATCH 2/5] dt-bindings: Add vendor prefix for emtrion GmbH Jan Tuerk
2017-11-23 12:58   ` Andreas Färber
2017-11-26 19:12   ` Rob Herring
2017-11-23 12:55 ` [PATCH 3/5] ARM: dts: imx: Add an cpu0 label for imx6dl devices Jan Tuerk
2017-11-23 13:00   ` Andreas Färber
2017-11-23 12:55 ` [PATCH 4/5] ARM: dts: Add support for emtrion emCON-MX6 series Jan Tuerk
2017-11-26 19:24   ` Rob Herring
2017-11-28 10:52     ` AW: " Türk, Jan
2017-11-23 12:55 ` [PATCH 5/5] ARM: imx_v6_v7_defconfig: Enable DA0963 PMIC support Jan Tuerk
2017-12-20 13:47 ` [PATCH v2 0/5] Add basic support for emtrion emCON-MX6 modules jan.tuerk
2017-12-20 13:47   ` [PATCH v2 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6 jan.tuerk
2017-12-21 22:59     ` Rob Herring
2018-04-20 12:50     ` [PATCH v3 0/6] Add basic support for emtrion emCON-MX6 modules jan.tuerk
2018-04-20 12:50       ` [PATCH v3 1/6] drm/panel: Add support for the EDT ETM0700G0BDH6 jan.tuerk
2018-04-20 12:50       ` [PATCH v3 2/6] drm/panel: Add support for the EDT ETM0700G0EDH6 jan.tuerk
2018-04-20 12:50       ` [PATCH v3 3/6] dt-bindings: display: Document the EDT et* displays in one file jan.tuerk
2018-04-20 12:50       ` [PATCH v3 4/6] ARM: dts: imx: Add an cpu0 label for imx6dl devices jan.tuerk
2018-04-20 12:50       ` [PATCH v3 5/6] ARM: dts: Add support for emtrion emCON-MX6 series jan.tuerk
2018-04-23  8:44         ` Shawn Guo
2018-04-24  8:32           ` AW: " Türk, Jan
2018-04-26 13:46             ` Rob Herring
2018-04-20 12:50       ` [PATCH v3 6/6] ARM: imx_v6_v7_defconfig: Enable DA0963 PMIC support jan.tuerk
2018-04-27 13:24       ` [PATCH v4 0/7] Add basic support for emtrion emCON-MX6 modules jan.tuerk
2018-04-27 13:24         ` [PATCH v4 1/7] dt-bindings: display: Document the EDT et* displays in one file jan.tuerk
2018-04-27 14:35           ` Rob Herring
2018-06-19  9:55           ` [PATCH 1/3] " jan.tuerk
2018-06-19  9:55             ` [PATCH 2/3] drm/panel: Add support for the EDT ETM0700G0BDH6 jan.tuerk
2018-06-19  9:55             ` [PATCH 3/3] drm/panel: Add support for the EDT ETM0700G0EDH6 jan.tuerk
2018-07-09 17:27             ` [PATCH 1/3] dt-bindings: display: Document the EDT et* displays in one file Thierry Reding
2018-04-27 13:24         ` [PATCH v4 2/7] drm/panel: Add support for the EDT ETM0700G0BDH6 jan.tuerk
2018-04-27 13:24         ` [PATCH v4 3/7] drm/panel: Add support for the EDT ETM0700G0EDH6 jan.tuerk
2018-04-27 13:24         ` [PATCH v4 4/7] ARM: dts: imx: Add an cpu0 label for imx6dl devices jan.tuerk
2018-04-27 13:24         ` [PATCH v4 5/7] dt-bindings: arm: Document emtrion emCON-MX6 bindings jan.tuerk
2018-04-27 14:45           ` Rob Herring
2018-04-27 13:24         ` [PATCH v4 6/7] ARM: dts: Add support for emtrion emCON-MX6 series jan.tuerk
2018-04-28  3:12           ` Shawn Guo
2018-05-03 10:00             ` AW: " Türk, Jan
2018-05-04  7:03               ` Shawn Guo
2018-04-27 13:24         ` [PATCH v4 7/7] ARM: imx_v6_v7_defconfig: Enable DA0963 PMIC support jan.tuerk
2018-04-28  2:34         ` [PATCH v4 0/7] Add basic support for emtrion emCON-MX6 modules Shawn Guo
2018-05-03 10:01           ` AW: " Türk, Jan
2018-08-22 15:51         ` [PATCH v5 1/4] ARM: dts: imx: Add an cpu0 label for imx6dl devices Jan Tuerk
2018-08-22 15:51           ` [PATCH v5 2/4] dt-bindings: arm: Document emtrion emCON-MX6 bindings Jan Tuerk
2018-08-22 15:51           ` [PATCH v5 3/4] ARM: dts: Add support for emtrion emCON-MX6 series Jan Tuerk
2018-08-22 15:51           ` [PATCH v5 4/4] ARM: imx_v6_v7_defconfig: Enable DA0963 PMIC support Jan Tuerk
2018-08-22 16:26             ` Fabio Estevam
2018-08-24 13:26           ` [PATCH v6 1/4] ARM: dts: imx: Add an cpu0 label for imx6dl devices Jan Tuerk
2018-08-24 13:26             ` [PATCH v6 2/4] dt-bindings: arm: Document emtrion emCON-MX6 bindings Jan Tuerk
2018-08-28 22:16               ` Rob Herring
2018-08-24 13:26             ` [PATCH v6 3/4] ARM: dts: Add support for emtrion emCON-MX6 series Jan Tuerk
2018-08-27  1:13               ` Shawn Guo
2018-08-24 13:26             ` [PATCH v6 4/4] ARM: imx_v6_v7_defconfig: Enable DA9063 PMIC support Jan Tuerk
2018-08-29 10:07             ` [PATCH v7 1/4] ARM: dts: imx: Add an cpu0 label for imx6dl devices Jan Tuerk
2018-08-29 10:07               ` [PATCH v7 2/4] dt-bindings: arm: Document emtrion emCON-MX6 bindings Jan Tuerk
2018-08-29 12:46                 ` Rob Herring
2018-08-29 10:07               ` [PATCH v7 3/4] ARM: dts: Add support for emtrion emCON-MX6 series Jan Tuerk
2018-08-29 10:08               ` [PATCH v7 4/4] ARM: imx_v6_v7_defconfig: Enable DA9063 PMIC support Jan Tuerk
2018-11-27 15:04               ` [PATCH v8 1/4] ARM: dts: imx: Add an cpu0 label for imx6dl devices Jan Tuerk
2018-11-27 15:04                 ` [PATCH v8 2/4] dt-bindings: arm: Document emtrion emCON-MX6 bindings Jan Tuerk
2018-11-27 15:04                 ` [PATCH v8 3/4] ARM: dts: Add support for emtrion emCON-MX6 series Jan Tuerk
2018-11-27 15:04                 ` [PATCH v8 4/4] ARM: imx_v6_v7_defconfig: Enable DA9063 PMIC support Jan Tuerk
2018-11-28  2:06                 ` [PATCH v8 1/4] ARM: dts: imx: Add an cpu0 label for imx6dl devices Shawn Guo
2017-12-20 13:47   ` [PATCH v2 2/5] dt-bindings: Add vendor prefix for emtrion GmbH jan.tuerk
2017-12-20 13:47   ` [PATCH v2 3/5] ARM: dts: imx: Add an cpu0 label for imx6dl devices jan.tuerk
2017-12-20 13:47   ` [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series jan.tuerk
2017-12-21 23:19     ` Rob Herring [this message]
2017-12-20 13:47   ` [PATCH v2 5/5] ARM: imx_v6_v7_defconfig: Enable DA0963 PMIC support jan.tuerk
2017-12-22 10:34 [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series Türk, Jan
2017-12-22 10:40 ` Alexandre Belloni
2017-12-22 10:43   ` Andreas Färber
2017-12-22 10:56     ` Alexandre Belloni
2017-12-26 17:16       ` Rob Herring
2017-12-28 13:57         ` Alexandre Belloni
2017-12-22 10:47 ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171221231905.e3fmhhbkzzrha5jg@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=afaerber@suse.de \
    --cc=airlied@linux.ie \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabio.estevam@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jan.tuerk@emtrion.com \
    --cc=kernel@pengutronix.de \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=shawnguo@kernel.org \
    --cc=sz.lin@moxa.com \
    --cc=thierry.reding@gmail.com \
    --subject='Re: [PATCH v2 4/5] ARM: dts: Add support for emtrion emCON-MX6 series' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).