From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754470AbeAGTFh (ORCPT + 1 other); Sun, 7 Jan 2018 14:05:37 -0500 Received: from mail5.windriver.com ([192.103.53.11]:40538 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754215AbeAGTFf (ORCPT ); Sun, 7 Jan 2018 14:05:35 -0500 Date: Sun, 7 Jan 2018 14:04:54 -0500 From: Paul Gortmaker To: Martin Kelly CC: , , , David Woodhouse , Matt Mackall , Masahiro Yamada , Michal Marek , Subject: Re: [PATCH] tools: fix cross-compile var export Message-ID: <20180107190453.GN6273@windriver.com> References: <20180106201601.11074-1-martin@martingkelly.com> <20180107161140.GM6273@windriver.com> <549cf839-9ae7-78ce-58df-3d84fc7b3d05@martingkelly.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <549cf839-9ae7-78ce-58df-3d84fc7b3d05@martingkelly.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: [Re: [PATCH] tools: fix cross-compile var export] On 07/01/2018 (Sun 10:31) Martin Kelly wrote: [...] > With the change, we add do CC = $(CROSS_COMPILE)gcc if and only if CC is not > already set. I'm happy to add all these details to the commit description. That is probably a step in the right direction. I contribute to yocto on a regular basis and hence am sympathetic to these frustrating SDK type issues. But after a quick scan of this patch it wasn't obvious to me that existing behaviour was preserved, or that it would be a pain to separate it into chunks. (key word here being "quick") So I'd recommend updating the commit log, and adding a Cc: line for the maintainers of each subsystem below, and then if nobody complains you might get akpm to pick it up as he does for other patches w/o a clear maintainer or subsystem. P. -- > > >> > >> tools/cgroup/Makefile | 1 - > >> tools/gpio/Makefile | 2 -- > >> tools/hv/Makefile | 1 - > >> tools/iio/Makefile | 2 -- > >> tools/laptop/freefall/Makefile | 1 - > >> tools/leds/Makefile | 1 - > >> tools/perf/Makefile.perf | 6 ------ > >> tools/power/acpi/Makefile.config | 3 --- > >> tools/scripts/Makefile.include | 18 ++++++++++++++++++ > >> tools/spi/Makefile | 2 -- > >> tools/usb/Makefile | 1 - > >> tools/vm/Makefile | 1 - > >> tools/wmi/Makefile | 1 - > >> 13 files changed, 18 insertions(+), 22 deletions(-) > >>