From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1948104-1518712545-2-15531629942316358386 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.001, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='net', MailFrom='org' X-Spam-charsets: X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-api-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1518712545; b=TRIOv7wYgvB9YkkTwN8Uc+R4yZZDfnO5yG/+E7sw43RIFw0 eDbKKSTS4Nb4pzIHUUKgrNoc8MK3PlHC07gONwf5TqIViYUQ/DsB+WW4ZFIa+9+g h2dC9LmUqeO3UkDgnAby/xKTfr7hqwDReXAN/aiEMjmqExrWaUkxuTZ16gzivoFX bHaBqEFDy5dADupOqJHSpijDcGTJFbJhkSF88Xr08FymJPc5tjv3AOwohP10h7BC M108sKfHhoOM/qE9ZGy9cwEZ56PE17QbHkZ3uhUr4rkhomz/YBvHyeEAy4iQt8eO N94u8202tIVKjv59h5s/rZrwEG6f3r2Mk1M+rbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id:sender :list-id; s=arctest; t=1518712545; bh=5BQw7SoSxxhYB0Q/cMOwICgm4r 3zg8sPUjYXFJIsKiA=; b=U+gRKo4B7b+WiRoA8uL0jvjkvNG22HsvucPywUJTif Wl3Co31mGU/kXVgPpzEX7SS9+NpOzsT1LPg5MG7ctZ1VcktLi3ZjR995bkC55+om HBQW0ZFlcUP+j3HiHPYHzuCl0HMcqmmyEVhYBFFxSOi+Imzap42mjRiF1DwvdMG5 0/fO4I+X124tI7mo36uLzYoYjRhChxQLg6SAllikumshrNBNvZ4DhfBA3sgnCClR hhOgP6uRdLHYUthavazuaFaU18WKB5tV8QIYlHzTrTEb4egmKuWf6792lUhMOhZB L0e0Zr7oV0zw1r6oHLFA1GvEe55j1Xv0KCjbG3zAeuxg== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=stgolabs.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=stgolabs.net header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=stgolabs.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-api-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=stgolabs.net header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424099AbeBOQeb (ORCPT ); Thu, 15 Feb 2018 11:34:31 -0500 Received: from smtp2.provo.novell.com ([137.65.250.81]:54071 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425903AbeBOQe2 (ORCPT ); Thu, 15 Feb 2018 11:34:28 -0500 From: Davidlohr Bueso To: akpm@linux-foundation.org Cc: mhocko@kernel.org, mtk.manpages@gmail.com, robert.kettler@outlook.com, manfred@colorfullife.com, ebiederm@xmission.com, keescook@chromium.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, dave@stgolabs.net Subject: [PATCH -next v2 0/3] sysvipc: introduce STAT_ANY commands Date: Thu, 15 Feb 2018 08:24:55 -0800 Message-Id: <20180215162458.10059-1-dave@stgolabs.net> X-Mailer: git-send-email 2.13.6 Sender: linux-api-owner@vger.kernel.org X-Mailing-List: linux-api@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Changes from v1 (https://lwn.net/Articles/747225/): - Renamed cmds to STAT_ANY, instead of STAT_ALL (per Eric). - Added Robert's reported-by tag. - Added changes for smack lsm. Hi, The following patches adds the discussed[1] new command for shm as well as for sems and msq as they are subject to the same discrepancies for ipc object permission checks between the syscall and via procfs. These new commands are justified in that (1) we are stuck with this semantics as changing syscall and procfs can break userland; and (2) some users can benefit from performance (for large amounts of shm segments, for example) from not having to parse the procfs interface. Once (if) merged, I will submit the necesary manpage updates. But I'm thinking something like: diff --git a/man2/shmctl.2 b/man2/shmctl.2 index 7bb503999941..bb00bbe21a57 100644 --- a/man2/shmctl.2 +++ b/man2/shmctl.2 @@ -41,6 +41,7 @@ .\" 2005-04-25, mtk -- noted aberrant Linux behavior w.r.t. new .\" attaches to a segment that has already been marked for deletion. .\" 2005-08-02, mtk: Added IPC_INFO, SHM_INFO, SHM_STAT descriptions. +.\" 2018-02-13, dbueso: Added SHM_STAT_ANY description. .\" .TH SHMCTL 2 2017-09-15 "Linux" "Linux Programmer's Manual" .SH NAME @@ -242,6 +243,18 @@ However, the argument is not a segment identifier, but instead an index into the kernel's internal array that maintains information about all shared memory segments on the system. +.TP +.BR SHM_STAT_ANY " (Linux-specific)" +Return a +.I shmid_ds +structure as for +.BR SHM_STAT . +However, the +.I shm_perm.mode +is not checked for read access for +.IR shmid , +resembing the behaviour of +/proc/sysvipc/shm. .PP The caller can prevent or allow swapping of a shared memory segment with the following \fIcmd\fP values: @@ -287,7 +300,7 @@ operation returns the index of the highest used entry in the kernel's internal array recording information about all shared memory segments. (This information can be used with repeated -.B SHM_STAT +.B SHM_STAT/SHM_STAT_ANY operations to obtain information about all shared memory segments on the system.) A successful @@ -328,7 +341,7 @@ isn't accessible. \fIshmid\fP is not a valid identifier, or \fIcmd\fP is not a valid command. Or: for a -.B SHM_STAT +.B SHM_STAT/SHM_STAT_ANY operation, the index value specified in .I shmid referred to an array slot that is currently unused. Thanks! [1] https://lkml.org/lkml/2017/12/19/220 *** BLURB HERE *** Davidlohr Bueso (3): ipc/shm: introduce shmctl(SHM_STAT_ANY) ipc/sem: introduce semctl(SEM_STAT_ANY) ipc/msg: introduce msgctl(MSG_STAT_ANY) include/uapi/linux/msg.h | 1 + include/uapi/linux/sem.h | 1 + include/uapi/linux/shm.h | 5 +++-- ipc/msg.c | 17 ++++++++++++----- ipc/sem.c | 17 ++++++++++++----- ipc/shm.c | 23 ++++++++++++++++++----- security/selinux/hooks.c | 3 +++ security/smack/smack_lsm.c | 3 +++ 8 files changed, 53 insertions(+), 17 deletions(-) -- 2.13.6