LKML Archive on
help / color / mirror / Atom feed
From: (Lennart Sorensen)
To: "Theodore Y. Ts'o" <>,
	Andreas Dilger <>,,
Subject: Re: ext4 ignoring rootfs default mount options
Date: Wed, 7 Mar 2018 11:15:15 -0500	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Wed, Mar 07, 2018 at 11:08:56AM -0500, Theodore Y. Ts'o wrote:
> This is where it's critcal to understand that the "tune2fs -o" changes
> the *default* mount options.  The key in the comment is the anything
> different from the *filesystem* defaults (that is, the defaults of the
> particular ext4 file system, as opposed to the global defaults).  The
> idea is that /proc/mounts, and /etc/mtab shows the options string that
> if used in /etc/fstab, or in the mount command line, will replicate
> the current mount option state.  Furthermore, that /proc/mounts is the
> minimal set of mount option strings.
> You may not like the behavior, but it's been this way forever, and the
> reasoning behind it is that the low-level file system code doesn't
> really know what the actual mount option string that would be in
> /etc/fstab or in the /sbin/mount command line.  That's because
> /sbin/mount command actually parses the mount options, and things like
> "ro" is actually translated into bitflag passed to the mount option.
> So for example, it's impossible to know whether "rw" was in the
> user-specified mount string, since we never see it by the time the
> string gets sent to ext4_fill_super (in fact the kernel never sees
> it).  So when we try to make /proc/mounts a replacement for /etc/mtab
> (since some people make /etc/mtab as symlink /proc/mounts), it's
> actually impossible.  Trying to make it be the minimal set of options
> was at least a consitent thing.  That is, if you use "tune2fs -o
> nodelalloc", it's not necessary to put nodelalloc in /etc/fstab or in
> the mount command line.  And hence, it should not be in /proc/mounts.

OK, that makes sense.  Thanks.  I will work on convincing myself this
is how it should be.

> As far as where ext4_seq_options_show() gets called, it's because we
> have a fair amount of macro shortcuts in fs/ext4/sysfs.c (which is
> where we put all of the pseudo file system support for ext4, which
> means it includes procfs).  Search for macros PROC_FILE_SHOW_DEFN and

Oh that's where it is.

Len Sorensen

  reply	other threads:[~2018-03-07 16:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 19:03 ext4 ignoring rootfs default mount options Lennart Sorensen
2018-03-07  4:06 ` Theodore Y. Ts'o
2018-03-07 15:14   ` Lennart Sorensen
2018-03-07 16:08     ` Theodore Y. Ts'o
2018-03-07 16:15       ` Lennart Sorensen [this message]
2018-03-07 19:13       ` Lennart Sorensen
2018-03-07 22:23         ` Tyson Nottingham
2018-03-07 22:50         ` Theodore Y. Ts'o
2018-03-15 18:35           ` Lennart Sorensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).