LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Alexander Duyck <alexander.duyck@gmail.com> To: bhelgaas@google.com, alexander.h.duyck@intel.com, linux-pci@vger.kernel.org Cc: virtio-dev@lists.oasis-open.org, kvm@vger.kernel.org, netdev@vger.kernel.org, dan.daly@intel.com, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, keith.busch@intel.com, netanel@amazon.com, ddutile@redhat.com, mheyne@amazon.de, liang-min.wang@intel.com, mark.d.rustad@intel.com, dwmw2@infradead.org, hch@lst.de, dwmw@amazon.co.uk Subject: [pci PATCH v7 3/5] ena: Migrate over to unmanaged SR-IOV support Date: Thu, 15 Mar 2018 11:43:21 -0700 [thread overview] Message-ID: <20180315184248.3102.16810.stgit@localhost.localdomain> (raw) In-Reply-To: <20180315183449.3102.64791.stgit@localhost.localdomain> From: Alexander Duyck <alexander.h.duyck@intel.com> Instead of implementing our own version of a SR-IOV configuration stub in the ena driver we can just reuse the existing pci_sriov_configure_simple function. Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com> --- v5: Replaced call to pci_sriov_configure_unmanaged with pci_sriov_configure_simple v6: Dropped "#ifdef" checks for IOV wrapping sriov_configure definition v7: No change drivers/net/ethernet/amazon/ena/ena_netdev.c | 28 +------------------------- 1 file changed, 1 insertion(+), 27 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index 6975150d144e..6054deb1e6aa 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c @@ -3385,32 +3385,6 @@ static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent) } /*****************************************************************************/ -static int ena_sriov_configure(struct pci_dev *dev, int numvfs) -{ - int rc; - - if (numvfs > 0) { - rc = pci_enable_sriov(dev, numvfs); - if (rc != 0) { - dev_err(&dev->dev, - "pci_enable_sriov failed to enable: %d vfs with the error: %d\n", - numvfs, rc); - return rc; - } - - return numvfs; - } - - if (numvfs == 0) { - pci_disable_sriov(dev); - return 0; - } - - return -EINVAL; -} - -/*****************************************************************************/ -/*****************************************************************************/ /* ena_remove - Device Removal Routine * @pdev: PCI device information struct @@ -3525,7 +3499,7 @@ static int ena_resume(struct pci_dev *pdev) .suspend = ena_suspend, .resume = ena_resume, #endif - .sriov_configure = ena_sriov_configure, + .sriov_configure = pci_sriov_configure_simple, }; static int __init ena_init(void)
next prev parent reply other threads:[~2018-03-15 18:43 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-15 18:40 [pci PATCH v7 0/5] Add support for unmanaged SR-IOV Alexander Duyck 2018-03-15 18:41 ` [pci PATCH v7 1/5] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources Alexander Duyck 2018-03-28 21:30 ` [virtio-dev] " Rustad, Mark D 2018-03-15 18:42 ` [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices Alexander Duyck 2018-03-16 16:34 ` [virtio-dev] " Michael S. Tsirkin 2018-03-16 16:40 ` Alexander Duyck 2018-04-03 13:12 ` Michael S. Tsirkin 2018-04-03 17:32 ` Alexander Duyck 2018-04-03 18:27 ` Michael S. Tsirkin 2018-04-03 19:06 ` Alexander Duyck 2018-04-20 0:40 ` Michael S. Tsirkin 2018-04-20 14:56 ` Alexander Duyck 2018-04-20 15:28 ` Michael S. Tsirkin 2018-04-20 16:08 ` Alexander Duyck 2018-04-20 16:14 ` Michael S. Tsirkin 2018-04-21 7:05 ` Christoph Hellwig 2018-04-03 19:18 ` Rustad, Mark D 2018-03-28 21:31 ` Rustad, Mark D 2018-04-03 13:11 ` [virtio-dev] " Michael S. Tsirkin 2018-03-15 18:43 ` Alexander Duyck [this message] 2018-03-15 18:43 ` [pci PATCH v7 4/5] nvme: Migrate over to unmanaged SR-IOV support Alexander Duyck 2018-03-15 18:44 ` [pci PATCH v7 5/5] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs Alexander Duyck 2018-03-16 21:42 ` [pci PATCH v7 0/5] Add support for unmanaged SR-IOV Don Dutile 2018-04-19 22:54 ` Alexander Duyck 2018-04-20 0:46 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180315184248.3102.16810.stgit@localhost.localdomain \ --to=alexander.duyck@gmail.com \ --cc=alexander.h.duyck@intel.com \ --cc=bhelgaas@google.com \ --cc=dan.daly@intel.com \ --cc=ddutile@redhat.com \ --cc=dwmw2@infradead.org \ --cc=dwmw@amazon.co.uk \ --cc=hch@lst.de \ --cc=keith.busch@intel.com \ --cc=kvm@vger.kernel.org \ --cc=liang-min.wang@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-pci@vger.kernel.org \ --cc=mark.d.rustad@intel.com \ --cc=mheyne@amazon.de \ --cc=netanel@amazon.com \ --cc=netdev@vger.kernel.org \ --cc=virtio-dev@lists.oasis-open.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).