LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: helgaas@kernel.org
Cc: khalid.aziz@oracle.com, sparclinux@vger.kernel.org,
	linux-pci@vger.kernel.org, yinghai@kernel.org,
	linux-kernel@vger.kernel.org, david.ahern@oracle.com,
	linux@iam.tj
Subject: Re: [PATCH v1 0/2] PCI: Sparc 64-bit resource fixups
Date: Mon, 19 Mar 2018 14:28:31 -0400 (EDT)	[thread overview]
Message-ID: <20180319.142831.793002554436316260.davem@davemloft.net> (raw)
In-Reply-To: <20180319171140.GA52750@bhelgaas-glaptop.roam.corp.google.com>

From: Bjorn Helgaas <helgaas@kernel.org>
Date: Mon, 19 Mar 2018 12:11:40 -0500

> I could have worded the changelog better.  This is about reserving PCI
> bus addresses 0xc0000-0xc7fff, not the VGA framebuffer at
> 0xa0000-0xbffff.
> 
> If I understand correctly, a VGA device will respond to the
> framebuffer at 0xa0000-0xbffff, but the device itself will not respond
> to the 0xc0000-0xc7fff range.  I think the typical x86 PC arrangement
> is that the BIOS reads the VGA option ROM using the normal relocatable
> expansion ROM BAR and copies it into system memory at 0xc0000, so it
> is in real physical memory.
> 
> I don't know what sparc firmware does, but I'm assuming the VGA PCI
> device behaves the same in that it wouldn't respond to 0xc0000 itself.

The Sparc firmware doesn't copy the VGA option ROM.

That physical address location 0xc0000 in system memory is just
normal memory and most likely the kernel image itself is residing
there.

>> I could understand removing the System ROM resource altogether, that
>> makes a lot of sense to me.
> 
> Do you want me to remove the System ROM resource?  If so, I'll
> make a separate patch to remove it, followed by one that does
> whatever we figure out is the right thing for the video ROM.

Porbably it makes the most sense to remove both, given the above.

  reply	other threads:[~2018-03-19 19:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 15:17 Bjorn Helgaas
2018-02-15 15:18 ` [PATCH v1 1/2] sparc/PCI: Support arbitrary host bridge address offset Bjorn Helgaas
2018-02-15 15:18 ` [PATCH v1 2/2] sparc/PCI: Reserve System ROM and Video ROM outside of PCI space Bjorn Helgaas
2018-02-20 23:39 ` [PATCH v1 0/2] PCI: Sparc 64-bit resource fixups Bjorn Helgaas
2018-02-21 20:37   ` Khalid Aziz
2018-03-18 16:07   ` David Miller
2018-03-19 17:11     ` Bjorn Helgaas
2018-03-19 18:28       ` David Miller [this message]
2018-03-19 19:38         ` Bjorn Helgaas
2018-03-19 23:33           ` David Miller
2018-03-20 20:14             ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180319.142831.793002554436316260.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=david.ahern@oracle.com \
    --cc=helgaas@kernel.org \
    --cc=khalid.aziz@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@iam.tj \
    --cc=sparclinux@vger.kernel.org \
    --cc=yinghai@kernel.org \
    --subject='Re: [PATCH v1 0/2] PCI: Sparc 64-bit resource fixups' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).