LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] staging: rtl8723bs/core/rtw_mlme_ext.c: Replace yield() call with cond_resched
@ 2018-03-20 21:45 Thomas Avery
  2018-03-22 17:16 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Avery @ 2018-03-20 21:45 UTC (permalink / raw)
  To: gregkh; +Cc: linux-kernel, kernel-janitors

Remove yield() call, yield() does not guarantee progress, and should not
be used. Cond_resched() is a safer alternative

Signed-off-by: Thomas Avery <tavery321@gmail.com>
---
 drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index 7d7756e40bcb..fdcc5b28af22 100644
--- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
@@ -4263,7 +4263,7 @@ unsigned int send_beacon(struct adapter *padapter)
 		issue_beacon(padapter, 100);
 		issue++;
 		do {
-			yield();
+			cond_resched();
 			rtw_hal_get_hwreg(padapter, HW_VAR_BCN_VALID, (u8 *)(&bxmitok));
 			poll++;
 		} while ((poll%10) != 0 && false == bxmitok && !padapter->bSurpriseRemoved && !padapter->bDriverStopped);
-- 
2.11.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] staging: rtl8723bs/core/rtw_mlme_ext.c: Replace yield() call with cond_resched
  2018-03-20 21:45 [PATCH] staging: rtl8723bs/core/rtw_mlme_ext.c: Replace yield() call with cond_resched Thomas Avery
@ 2018-03-22 17:16 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-03-22 17:16 UTC (permalink / raw)
  To: Thomas Avery; +Cc: linux-kernel, kernel-janitors

On Tue, Mar 20, 2018 at 05:45:41PM -0400, Thomas Avery wrote:
> Remove yield() call, yield() does not guarantee progress, and should not
> be used. Cond_resched() is a safer alternative
> 
> Signed-off-by: Thomas Avery <tavery321@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You sent me 3 patches in 2 days with almost the same subject for the
same driver.  Please resend them as a patch series so I know what order
to apply them in.

Also, always use scripts/get_maintainer.pl to find the proper people and
mailing lists to cc:

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-03-22 17:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-20 21:45 [PATCH] staging: rtl8723bs/core/rtw_mlme_ext.c: Replace yield() call with cond_resched Thomas Avery
2018-03-22 17:16 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).