LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Abderrahmane Benbachir <abderrahmane.benbachir@polymtl.ca>
Cc: mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] ftrace: support boot level tracing
Date: Thu, 22 Mar 2018 19:25:38 -0400	[thread overview]
Message-ID: <20180322192538.76164265@gandalf.local.home> (raw)
In-Reply-To: <20180320233546.Horde.R7YJoHwgHhxvd5TuazyH3GI@www.imp.polymtl.ca>

On Tue, 20 Mar 2018 23:35:46 +0000
Abderrahmane Benbachir <abderrahmane.benbachir@polymtl.ca> wrote:

> Steven Rostedt <rostedt@goodmis.org> a écrit :
> 
> > On Tue, 20 Mar 2018 14:22:56 -0400
> > Abderrahmane Benbachir <abderrahmane.benbachir@polymtl.ca> wrote:
> >
> > Would something like this work for you?  
> 
> Yes this is working great. I have also instrumented console and security
> initcalls, I used your previous patch, changes are below.
> 
> > +	trace_initcall_level("pre_smp_initcalls");  
> 
> This should be "early" I guess : trace_initcall_level("ealry");

Hmm, I think I found an issue with what's there. I made up that name
because "early" was already taken.

> 
> 
> output of : trace_event=initcall_level
> 
> [    0.327032]   <idle>-0       0.... 89576us : initcall_level: level=console
> [    0.327454]   <idle>-0       0.... 135819us : initcall_level:  
> level=security
> [    0.327887] swapper/-1       0.... 261166us : initcall_level: level=early
> [    0.328306] swapper/-1       0.... 265248us : initcall_level: level=early

Noticed you have two "early"s.

The second early should be "pure". But that's an issue with init.c.

I'll apply mine (with minor updates) and add diffs by you. Care to give
me a "signed-off-by" for the console and security change.

-- Steve


> [    0.328742] swapper/-1       0.... 267969us : initcall_level: level=core
> [    0.329158] swapper/-1       0.... 270111us : initcall_level:  
> level=postcore
> [    0.329590] swapper/-1       0.... 271111us : initcall_level: level=arch
> [    0.330007] swapper/-1       0.... 272217us : initcall_level: level=subsys
> [    0.330429] swapper/-1       0.... 316236us : initcall_level: level=fs
> [    0.330833] swapper/-1       0.... 340523us : initcall_level: level=device
> [    0.331254] swapper/-1       0.... 388737us : initcall_level: level=late
> 
> PATCH with security and console instrumented
> 
> 

      reply	other threads:[~2018-03-22 23:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20 18:22 Abderrahmane Benbachir
2018-03-20 22:01 ` Steven Rostedt
2018-03-20 23:35   ` Abderrahmane Benbachir
2018-03-22 23:25     ` Steven Rostedt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180322192538.76164265@gandalf.local.home \
    --to=rostedt@goodmis.org \
    --cc=abderrahmane.benbachir@polymtl.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --subject='Re: [RFC PATCH] ftrace: support boot level tracing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).