LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Sitsofe Wheeler <sitsofe@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
	Stefan Haberland <sth@linux.vnet.ibm.com>,
	Jan Hoeppner <hoeppner@linux.vnet.ibm.com>,
	Bart Van Assche <Bart.VanAssche@wdc.com>
Subject: Re: [BISECTED][REGRESSION] Hang while booting EeePC 900
Date: Mon, 2 Apr 2018 13:29:51 -0700	[thread overview]
Message-ID: <20180402202951.GE388343@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <CALjAwxgtuEv=d1TfvH3EdXqZs=_6F7TinyVhbPdUmTsdK_5ghw@mail.gmail.com>

Hello, Sitsofe.

Can you see whether the following patch makes any difference?

Thanks.

diff --git a/block/blk-timeout.c b/block/blk-timeout.c
index a05e367..f0e6e41 100644
--- a/block/blk-timeout.c
+++ b/block/blk-timeout.c
@@ -165,7 +165,7 @@ void blk_abort_request(struct request *req)
 		 * No need for fancy synchronizations.
 		 */
 		blk_rq_set_deadline(req, jiffies);
-		mod_timer(&req->q->timeout, 0);
+		kblockd_schedule_work(&req->q->timeout_work);
 	} else {
 		if (blk_mark_rq_complete(req))
 			return;

  reply	other threads:[~2018-04-02 20:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-01 14:35 Sitsofe Wheeler
2018-04-02 13:47 ` Bart Van Assche
2018-04-02 14:33 ` Jens Axboe
2018-04-02 17:32   ` Sitsofe Wheeler
2018-04-02 20:29     ` Tejun Heo [this message]
2018-04-02 21:02       ` Sitsofe Wheeler
2018-04-02 22:04         ` [PATCH] blk-mq: Directly schedule q->timeout_work when aborting a request Tejun Heo
2018-04-02 22:35           ` Jens Axboe
2018-04-06 20:06           ` Sasha Levin
2018-04-10 18:43           ` Martin Steigerwald
2018-04-10 20:46             ` Martin Steigerwald
2018-04-05  8:14       ` [BISECTED][REGRESSION] Hang while booting EeePC 900 Sitsofe Wheeler
2018-04-05 14:42         ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180402202951.GE388343@devbig577.frc2.facebook.com \
    --to=tj@kernel.org \
    --cc=Bart.VanAssche@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hoeppner@linux.vnet.ibm.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sitsofe@gmail.com \
    --cc=sth@linux.vnet.ibm.com \
    --subject='Re: [BISECTED][REGRESSION] Hang while booting EeePC 900' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).