LKML Archive on
help / color / mirror / Atom feed
From: Enric Balletbo i Serra <>
Cc:,,,,, Joseph Lo <>
Subject: [PATCH v5 8/8] mfd: cros_ec_i2c: moving the system sleep pm ops to late
Date: Thu,  5 Apr 2018 13:33:13 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Joseph Lo <>

The cros_ec_i2c driver is still active after it had suspended or before it
resumes. Besides that, it also tried to transfer data even after the I2C
host had been suspended. This will lead the system to crash.

During the test, we also observe that the EC needs to be resumed earlier
due to some status polling from the EC FW (e.g. battery status). So we
move the PM ops to late stage to make it work normally.

Signed-off-by: Joseph Lo <>
Signed-off-by: Enric Balletbo i Serra <>
Reviewed-by: Andy Shevchenko <>
Acked-by: Lee Jones <>

Changes in v5: None
Changes in v4:
- [8/8] Add Acked-by Lee Jones.

Changes in v3:
- [8/8] Add static to cros_ec_i2c_pm_ops.
- [8/8] Add the Reviewed-by Andy Shevchenko.

Changes in v2:
- [8/8] This patch is new in this series replacing [5/6] of v1.

 drivers/mfd/cros_ec_i2c.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/mfd/cros_ec_i2c.c b/drivers/mfd/cros_ec_i2c.c
index 02a7bacdc056..ef9b4763356f 100644
--- a/drivers/mfd/cros_ec_i2c.c
+++ b/drivers/mfd/cros_ec_i2c.c
@@ -342,8 +342,9 @@ static int cros_ec_i2c_resume(struct device *dev)
-static SIMPLE_DEV_PM_OPS(cros_ec_i2c_pm_ops, cros_ec_i2c_suspend,
-			  cros_ec_i2c_resume);
+static const struct dev_pm_ops cros_ec_i2c_pm_ops = {
+	SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_i2c_suspend, cros_ec_i2c_resume)
 #ifdef CONFIG_OF
 static const struct of_device_id cros_ec_i2c_of_match[] = {

      parent reply	other threads:[~2018-04-05 11:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-05 11:33 [PATCH v5 0/8] mfd: cros_ec: add subdevices and fixes Enric Balletbo i Serra
2018-04-05 11:33 ` [PATCH v5 1/8] mfd: cros_ec: fail early if we cannot identify the EC Enric Balletbo i Serra
2018-04-05 11:33 ` [PATCH v5 2/8] mfd: cros_ec: free IRQ automatically Enric Balletbo i Serra
2018-04-05 11:33 ` [PATCH v5 3/8] mfd: cros_ec: Don't try to grab log when suspended Enric Balletbo i Serra
2018-04-05 11:33 ` [PATCH v5 4/8] mfd: cros_ec_dev: Register cros-ec-rtc driver as a subdevice Enric Balletbo i Serra
2018-04-16 14:06   ` Lee Jones
2018-04-05 11:33 ` [PATCH v5 5/8] mfd: cros_ec_dev: Register cros_ec_accel_legacy " Enric Balletbo i Serra
2018-04-05 11:33 ` [PATCH v5 6/8] mfd: cros_ec_dev: register shutdown function for debugfs Enric Balletbo i Serra
2018-04-05 11:33 ` [PATCH v5 7/8] mfd: cros_ec_i2c: add ACPI module device table Enric Balletbo i Serra
2018-04-05 11:33 ` Enric Balletbo i Serra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH v5 8/8] mfd: cros_ec_i2c: moving the system sleep pm ops to late' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).