From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751356AbeDEMTR (ORCPT ); Thu, 5 Apr 2018 08:19:17 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:46172 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751038AbeDEMTP (ORCPT ); Thu, 5 Apr 2018 08:19:15 -0400 X-Google-Smtp-Source: AIpwx4+Ai8NUdLpSdxZPaF25T+Ptqgu7bTpEId0CwxIpIPNkFY/zXfVSEMvfottcFzt9osTnKWVwMw== Date: Thu, 5 Apr 2018 08:19:06 -0400 From: William Breathitt Gray To: Colin King Cc: Linus Walleij , linux-gpio@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpio: 104-dio-48e: make array 'ports' static, shrinks object size Message-ID: <20180405121906.GA6274@sophia> References: <20180405120012.7671-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180405120012.7671-1-colin.king@canonical.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 05, 2018 at 01:00:12PM +0100, Colin King wrote: >From: Colin Ian King > >Don't populate the const read-only array 'ports' on the stack but instead >make it static. Makes the object code smaller by over 100 buytes: > >Before: > text data bss dec hex filename > 10959 4952 832 16743 4167 drivers/gpio/gpio-104-dio-48e.o > >After: > text data bss dec hex filename > 10790 5008 832 16630 40f6 drivers/gpio/gpio-104-dio-48e.o > >(gcc version 7.2.0 x86_64) > >Signed-off-by: Colin Ian King >--- > drivers/gpio/gpio-104-dio-48e.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/gpio/gpio-104-dio-48e.c b/drivers/gpio/gpio-104-dio-48e.c >index 31e22c93e844..9c4e07fcb74b 100644 >--- a/drivers/gpio/gpio-104-dio-48e.c >+++ b/drivers/gpio/gpio-104-dio-48e.c >@@ -188,7 +188,7 @@ static int dio48e_gpio_get_multiple(struct gpio_chip *chip, unsigned long *mask, > { > struct dio48e_gpio *const dio48egpio = gpiochip_get_data(chip); > size_t i; >- const size_t ports[] = { 0, 1, 2, 4, 5, 6 }; >+ static const size_t ports[] = { 0, 1, 2, 4, 5, 6 }; > const unsigned int gpio_reg_size = 8; > unsigned int bits_offset; > size_t word_index; >-- >2.15.1 > If this makes gpio-104-dio-48e.o smaller, then it may be worthwhile to apply similar changes to gpio-104-idi-48.c and gpio-gpio-mm.c which have similar get_multiple callback implementations. Acked-by: William Breathitt Gray