LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Niklas Cassel <niklas.cassel@linaro.org>
To: srinivas.kandagatla@linaro.org
Cc: andy.gross@linaro.org, linux-arm-msm@vger.kernel.org,
	david.brown@linaro.org, robh+dt@kernel.org,
	linux-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [v2] ARM: dts: qcom: Add apq8064 Dragon Board 600c support
Date: Thu, 5 Apr 2018 21:11:37 +0200	[thread overview]
Message-ID: <20180405191137.GA17656@localhost.localdomain> (raw)
In-Reply-To: <20180316215436.22906-1-srinivas.kandagatla@linaro.org>

On Fri, Mar 16, 2018 at 09:54:36PM +0000, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> 
> This patch add support to DB600c board, which is another
> 96boards based on Qualcomm APQ8064 SoC.
> 
> Support for USB, HDMI, PCIe, I2C, SPI, eMMC, microSD card, LEDs
> device tree nodes is added in this patch.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> Changes since v1:
> 	- added chosen node with stdout, suggested by Stephen Boyd
> 	- removed spi flash node and gpio22 pinconf, as its not required in this patch.
> 	- removed extra comment lines and fix a node name, spotted by Stephen Boyd.
> 
>  arch/arm/boot/dts/Makefile                |   1 +
>  arch/arm/boot/dts/qcom-apq8064-db600c.dts | 530 ++++++++++++++++++++++++++++++
>  2 files changed, 531 insertions(+)
>  create mode 100644 arch/arm/boot/dts/qcom-apq8064-db600c.dts

Hello Srini (I hope you had a nice vacation!)


Running checkpatch on this patch gives a few of these warnings:

WARNING: line over 80 characters

These can probably be ignored, since they exist for most
arch/arm/boot/dts/qcom-*.dts files.


However, it also gives a few of these errors:

ERROR: trailing whitespace

These should probably be fixed, since the are errors and not warnings.


Kind regards,
Niklas

  reply	other threads:[~2018-04-05 19:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16 21:54 [PATCH v2] " srinivas.kandagatla
2018-04-05 19:11 ` Niklas Cassel [this message]
2018-04-20  7:37 ` Loic Poulain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180405191137.GA17656@localhost.localdomain \
    --to=niklas.cassel@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --subject='Re: [v2] ARM: dts: qcom: Add apq8064 Dragon Board 600c support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).