LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Greer <mgreer@animalcreek.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Mark Greer <mgreer@animalcreek.com>,
Gaurav Dhingra <gauravdhingra.gxyd@gmail.com>,
Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: greybus: Fix warning to limit chars per line
Date: Fri, 6 Apr 2018 09:01:34 -0700 [thread overview]
Message-ID: <20180406160134.GB21252@animalcreek.com> (raw)
In-Reply-To: <CAOh2x==-Ayr40WhMNmABVEjaoFfSwQfyN8SH07mzmZTicLBh-A@mail.gmail.com>
On Fri, Apr 06, 2018 at 10:52:17AM +0530, Viresh Kumar wrote:
> On Fri, Apr 6, 2018 at 3:49 AM, Mark Greer <mgreer@animalcreek.com> wrote:
> > On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote:
> >> Wrap comment to fix warning "prefer a maximum 75 chars per line"
> >>
> >> Signed-off-by: Gaurav Dhingra <gauravdhingra.gxyd@gmail.com>
> >> ---
> >> drivers/staging/greybus/audio_codec.h | 4 +++-
> >> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
> >> index a1d5440..01838d9 100644
> >> --- a/drivers/staging/greybus/audio_codec.h
> >> +++ b/drivers/staging/greybus/audio_codec.h
> >> @@ -23,7 +23,9 @@ enum {
> >> NUM_CODEC_DAIS,
> >> };
> >>
> >> -/* device_type should be same as defined in audio.h (Android media layer) */
> >> +/* device_type should be same as defined in audio.h
>
> This isn't the right way to write a multi-line comment. It should be like:
>
> /*
> * XXXX
> * XXXX
> */
Ugh, yeah, you're right. I must have been sleeping.
Mark
--
prev parent reply other threads:[~2018-04-06 16:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 18:32 Gaurav Dhingra
2018-04-05 7:17 ` Gaurav Dhingra
2018-04-05 12:37 ` Greg KH
2018-04-05 22:19 ` Mark Greer
2018-04-06 5:22 ` Viresh Kumar
2018-04-06 10:17 ` Gaurav Dhingra
2018-04-06 10:25 ` Viresh Kumar
2018-04-06 10:26 ` Viresh Kumar
2018-04-06 10:29 ` Gaurav Dhingra
2018-04-06 16:01 ` Mark Greer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180406160134.GB21252@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=elder@kernel.org \
--cc=gauravdhingra.gxyd@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
--subject='Re: [PATCH] staging: greybus: Fix warning to limit chars per line' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).