LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 4/4] zram: introduce zram memory tracking
Date: Tue, 10 Apr 2018 09:03:05 +0900	[thread overview]
Message-ID: <20180410000305.GA6942@jagdpanzerIV> (raw)
In-Reply-To: <20180409055435.135695-5-minchan@kernel.org>

Hi Minchan,

On (04/09/18 14:54), Minchan Kim wrote:
> +static long long ns2usecs(u64 nsec)
> +{
> +	nsec += 500;
> +	do_div(nsec, 1000);
> +	return nsec;
> +}

Sorry, I don't quite understand "nsec += 500".

> +static ssize_t read_block_state(struct file *file, char __user *buf,
> +				size_t count, loff_t *ppos)
> +{
[..]
> +
> +	up_read(&zram->init_lock);
> +	copy_to_user(buf, kbuf, written);

drivers/block/zram/zram_drv.c: In function ‘read_block_state’:
drivers/block/zram/zram_drv.c:701:2: warning: ignoring return value of ‘copy_to_user’, declared with attribute warn_unused_result [-Wunused-result]
  copy_to_user(buf, kbuf, written);
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[..]
> @@ -61,7 +61,9 @@ struct zram_table_entry {
>  		unsigned long element;
>  	};
>  	unsigned long value;
> +#ifdef	CONFIG_ZRAM_MEMORY_TRACKING

A silly nitpick, but since you are going to resend this one, could you
remove TAB between ifdef and CONFIG_ZRAM_MEMORY_TRACKING?

	-ss

  parent reply	other threads:[~2018-04-10  0:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-09  5:54 [PATCH v3 0/4] zram memory tracking Minchan Kim
2018-04-09  5:54 ` [PATCH v3 1/4] zram: correct flag name of ZRAM_ACCESS Minchan Kim
2018-04-09  5:54 ` [PATCH v3 2/4] zram: mark incompressible page as ZRAM_HUGE Minchan Kim
2018-04-09  5:54 ` [PATCH v3 3/4] zram: record accessed second Minchan Kim
2018-04-09  5:54 ` [PATCH v3 4/4] zram: introduce zram memory tracking Minchan Kim
2018-04-09  8:03   ` Greg KH
2018-04-09 22:39     ` Minchan Kim
2018-04-10  0:03   ` Sergey Senozhatsky [this message]
2018-04-10  0:41     ` Sergey Senozhatsky
2018-04-10  6:22       ` Minchan Kim
2018-04-10  6:22     ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180410000305.GA6942@jagdpanzerIV \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minchan@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).