LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: intel-gfx@lists.freedesktop.org
Cc: "Manasi Navare" <manasi.d.navare@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Gustavo Padovan" <gustavo@padovan.org>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Sean Paul" <seanpaul@chromium.org>,
"David Airlie" <airlied@linux.ie>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 04/10] drm/dp_mst: Remove all evil duplicate state pointers
Date: Wed, 11 Apr 2018 18:54:41 -0400 [thread overview]
Message-ID: <20180411225501.26751-5-lyude@redhat.com> (raw)
In-Reply-To: <20180411225501.26751-1-lyude@redhat.com>
There's no reason to track the atomic state three times. Unfortunately,
this is currently what we're doing, and even worse is that there is only
one actually correct state pointer: the one in mst_state->base.state.
mgr->state never seems to be used, along with the one in
mst_state->state.
This confused me for over 4 hours until I realized there was no magic
behind these pointers. So, let's save everyone else from the trouble.
Signed-off-by: Lyude Paul <lyude@redhat.com>.
Cc: Manasi Navare <manasi.d.navare@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
include/drm/drm_dp_mst_helper.h | 6 ------
1 file changed, 6 deletions(-)
diff --git a/include/drm/drm_dp_mst_helper.h b/include/drm/drm_dp_mst_helper.h
index 2f6203407fd2..5ca77dcf4f90 100644
--- a/include/drm/drm_dp_mst_helper.h
+++ b/include/drm/drm_dp_mst_helper.h
@@ -409,7 +409,6 @@ struct drm_dp_payload {
struct drm_dp_mst_topology_state {
struct drm_private_state base;
int avail_slots;
- struct drm_atomic_state *state;
struct drm_dp_mst_topology_mgr *mgr;
};
@@ -497,11 +496,6 @@ struct drm_dp_mst_topology_mgr {
*/
int pbn_div;
- /**
- * @state: State information for topology manager
- */
- struct drm_dp_mst_topology_state *state;
-
/**
* @funcs: Atomic helper callbacks
*/
--
2.14.3
next prev parent reply other threads:[~2018-04-11 22:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 22:54 [PATCH v7 00/10] drm/i915: Implement proper fallback training for MST Lyude Paul
2018-04-11 22:54 ` [PATCH v7 01/10] drm/atomic: Print debug message on atomic check failure Lyude Paul
2018-04-11 22:54 ` [PATCH v7 02/10] drm/i915: Move DP modeset retry work into intel_dp Lyude Paul
2018-04-24 22:52 ` [Intel-gfx] " Dhinakaran Pandiyan
2018-04-11 22:54 ` [PATCH v7 03/10] drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state() Lyude Paul
2018-04-11 22:54 ` Lyude Paul [this message]
2018-04-11 22:54 ` [PATCH v7 05/10] drm/dp_mst: Make drm_dp_mst_topology_state subclassable Lyude Paul
2018-04-11 22:54 ` [PATCH v7 06/10] drm/dp_mst: Add reset_state callback to topology mgr Lyude Paul
2018-04-11 22:54 ` [PATCH v7 07/10] drm/i915: Only use one link bw config for MST topologies Lyude Paul
2018-04-11 22:54 ` [PATCH v7 08/10] drm/i915: Make intel_dp_mst_atomic_check() idempotent Lyude Paul
2018-04-11 22:54 ` [PATCH v7 09/10] drm/dp_mst: Add MST fallback retraining helpers Lyude Paul
2018-04-11 22:54 ` [PATCH v7 10/10] drm/i915: Implement proper fallback training for MST Lyude Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180411225501.26751-5-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=manasi.d.navare@intel.com \
--cc=seanpaul@chromium.org \
--cc=ville.syrjala@linux.intel.com \
--subject='Re: [PATCH v7 04/10] drm/dp_mst: Remove all evil duplicate state pointers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).