LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Johan Hovold <johan@kernel.org>
Cc: Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Arnd Bergmann <arnd@arndb.de>,
Kishon Vijay Abraham I <kishon@ti.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH 1/3] USB: musb: dsps: drop duplicate phy initialisation
Date: Fri, 13 Apr 2018 20:45:15 +0200 [thread overview]
Message-ID: <20180413184515.4qg24ksghap7s5hd@pengutronix.de> (raw)
In-Reply-To: <20180413151505.32663-2-johan@kernel.org>
On Fri, Apr 13, 2018 at 05:15:03PM +0200, Johan Hovold wrote:
> Since commit 39cee200c23e ("usb: musb: core: call init and shutdown for
> the usb phy") the musb USB phy is initialised by musb_core, but the
> original initialisation in the dsps-glue init callback was left in
> place resulting in two calls to phy init during probe (and similarly,
> two shutdowns on remove).
>
> Drop the duplicate phy init and shutdown calls from the dsps glue in
> favour of the ones in musb core, which other glue drivers rely on.
Hmm, I don't remember the details of my debug session that led to
39cee200c23e, and I don't have access to the hardware in question any
more.
But your commit logs makes sense, so
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Given that it took 2+ years to find this, backporting to stable and a
Fixes: line are probably not necessary.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2018-04-13 18:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-13 15:15 [PATCH 0/3] USB: musb: dsps: phy fix and DT-topology support Johan Hovold
2018-04-13 15:15 ` [PATCH 1/3] USB: musb: dsps: drop duplicate phy initialisation Johan Hovold
2018-04-13 18:45 ` Uwe Kleine-König [this message]
2018-04-13 15:15 ` [PATCH 2/3] USB: musb: host: prevent core " Johan Hovold
2018-04-13 15:15 ` [PATCH 3/3] USB: musb: dsps: propagate device-tree node Johan Hovold
2018-04-16 20:03 ` Bin Liu
2018-04-17 7:07 ` Johan Hovold
2018-04-18 16:20 ` [PATCH 0/3] USB: musb: dsps: phy fix and DT-topology support Bin Liu
2018-04-18 18:46 ` Johan Hovold
2018-04-18 18:56 ` Bin Liu
2018-04-18 19:18 ` Martin Blumenstingl
2018-04-19 7:43 ` Johan Hovold
2018-04-19 21:54 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413184515.4qg24ksghap7s5hd@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=arnd@arndb.de \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=stern@rowland.harvard.edu \
--subject='Re: [PATCH 1/3] USB: musb: dsps: drop duplicate phy initialisation' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).