LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] ARM: s3c24xx: mini2440: use device properties for at24 eeprom
@ 2018-04-04 11:51 Bartosz Golaszewski
  2018-04-05 11:16 ` Krzysztof Kozlowski
  2018-04-16 18:18 ` Krzysztof Kozlowski
  0 siblings, 2 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2018-04-04 11:51 UTC (permalink / raw)
  To: Kukjin Kim, Krzysztof Kozlowski, Russell King
  Cc: linux-arm-kernel, linux-samsung-soc, linux-kernel, Bartosz Golaszewski

We want to work towards phasing out the at24_platform_data structure.
There are few users and its contents can be represented using generic
device properties. Using device properties only will allow us to
significantly simplify the at24 configuration code.

Remove the at24_platform_data structure and replace it with an array
of property entries. Drop the byte_len/size property, as the model name
already implies the EEPROM's size.

Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---
 arch/arm/mach-s3c24xx/mach-mini2440.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-s3c24xx/mach-mini2440.c b/arch/arm/mach-s3c24xx/mach-mini2440.c
index 95753e0bc073..f9fc1f8d2b28 100644
--- a/arch/arm/mach-s3c24xx/mach-mini2440.c
+++ b/arch/arm/mach-s3c24xx/mach-mini2440.c
@@ -20,7 +20,7 @@
 #include <linux/serial_core.h>
 #include <linux/serial_s3c.h>
 #include <linux/dm9000.h>
-#include <linux/platform_data/at24.h>
+#include <linux/property.h>
 #include <linux/platform_device.h>
 #include <linux/gpio_keys.h>
 #include <linux/i2c.h>
@@ -481,15 +481,15 @@ static struct platform_device mini2440_audio = {
 /*
  * I2C devices
  */
-static struct at24_platform_data at24c08 = {
-	.byte_len	= SZ_8K / 8,
-	.page_size	= 16,
+static const struct property_entry mini2440_at24_properties[] = {
+	PROPERTY_ENTRY_U32("pagesize", 16),
+	{ }
 };
 
 static struct i2c_board_info mini2440_i2c_devs[] __initdata = {
 	{
 		I2C_BOARD_INFO("24c08", 0x50),
-		.platform_data = &at24c08,
+		.properties = mini2440_at24_properties,
 	},
 };
 
-- 
2.16.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: s3c24xx: mini2440: use device properties for at24 eeprom
  2018-04-04 11:51 [PATCH] ARM: s3c24xx: mini2440: use device properties for at24 eeprom Bartosz Golaszewski
@ 2018-04-05 11:16 ` Krzysztof Kozlowski
  2018-04-16 18:18 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2018-04-05 11:16 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Kukjin Kim, Russell King, linux-arm-kernel, linux-samsung-soc,
	linux-kernel

On Wed, Apr 4, 2018 at 1:51 PM, Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> We want to work towards phasing out the at24_platform_data structure.
> There are few users and its contents can be represented using generic
> device properties. Using device properties only will allow us to
> significantly simplify the at24 configuration code.
>
> Remove the at24_platform_data structure and replace it with an array
> of property entries. Drop the byte_len/size property, as the model name
> already implies the EEPROM's size.
>
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>

Looks ok, I will take it after merge window.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ARM: s3c24xx: mini2440: use device properties for at24 eeprom
  2018-04-04 11:51 [PATCH] ARM: s3c24xx: mini2440: use device properties for at24 eeprom Bartosz Golaszewski
  2018-04-05 11:16 ` Krzysztof Kozlowski
@ 2018-04-16 18:18 ` Krzysztof Kozlowski
  1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2018-04-16 18:18 UTC (permalink / raw)
  To: Bartosz Golaszewski
  Cc: Kukjin Kim, Russell King, linux-arm-kernel, linux-samsung-soc,
	linux-kernel

On Wed, Apr 04, 2018 at 01:51:47PM +0200, Bartosz Golaszewski wrote:
> We want to work towards phasing out the at24_platform_data structure.
> There are few users and its contents can be represented using generic
> device properties. Using device properties only will allow us to
> significantly simplify the at24 configuration code.
> 
> Remove the at24_platform_data structure and replace it with an array
> of property entries. Drop the byte_len/size property, as the model name
> already implies the EEPROM's size.
> 
> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> ---
>  arch/arm/mach-s3c24xx/mach-mini2440.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

Thanks, applied.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-16 18:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-04 11:51 [PATCH] ARM: s3c24xx: mini2440: use device properties for at24 eeprom Bartosz Golaszewski
2018-04-05 11:16 ` Krzysztof Kozlowski
2018-04-16 18:18 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).