LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Peter Rosin <firstname.lastname@example.org> To: email@example.com Cc: Peter Rosin <firstname.lastname@example.org>, David Airlie <email@example.com>, Rob Herring <firstname.lastname@example.org>, Mark Rutland <email@example.com>, Nicolas Ferre <firstname.lastname@example.org>, Alexandre Belloni <email@example.com>, Boris Brezillon <firstname.lastname@example.org>, Daniel Vetter <email@example.com>, Gustavo Padovan <firstname.lastname@example.org>, Sean Paul <email@example.com>, Laurent Pinchart <firstname.lastname@example.org>, Russell King - ARM Linux <email@example.com>, firstname.lastname@example.org, email@example.com, firstname.lastname@example.org Subject: [PATCH v2 0/6] Add tda998x (HDMI) support to atmel-hlcdc Date: Tue, 17 Apr 2018 15:10:46 +0200 [thread overview] Message-ID: <email@example.com> (raw) Hi! I naively thought that since there was support for both nxp,tda19988 (in the tda998x driver) and the atmel-hlcdc, things would be a smooth ride. But it wasn't, so I started looking around, and found some missing pieces in the tilcdc driver. I "stole" some things and made it work for my use case. In addition to the above, our PCB interface between the SAMA5D3 and the HDMI encoder is only using 16 bits, and this has to be described somewhere, or the atmel-hlcdc driver have no chance of selecting the correct output mode. Since I had similar problems with ds90c185 lvds encoder I added patches to override the atmel-hlcdc output format via DT properties compatible with the media video-interface binding and things start to play together. Since this series superseeds the bridge series , I have included the leftover bindings patch for the ti,ds90c185 here. I also noticed that the driver date for atmel-hlcdc is bonkers, and added a patch for that. However, I don't know if the tilcdc driver is interfacing with the tda998x driver in a sane and modern way, and I don't know if I have missed any subtle point when I "stole" the code and componentized the atmel-hlcdc driver. I also have not tested how this behaves if I run with the components as modules (not targeting that). Further, I'm not sure if I interpret the media video-interface binding correctly. Anyway, this series solves some real issues for my HW. Cheers, Peter Changes since v1 https://lkml.org/lkml/2018/4/9/294 - added reviewed-by from Rob to patch 1/6 - patch 2/6 changed so that the bus format override is in the endpoint DT node, and follows the binding of media video-interfaces. - patch 3/6 is new, it adds drm_of_media_bus_fmt which parses above media video-interface binding (partially). - patch 4/6 now makes use of the above helper (and also fixes problems with the 3/5 patch from v1 when no override was specified). - do not mention unrelated connector display_info details in the cover letter and commit messages.  "Bridge" series v2 https://lkml.org/lkml/2018/3/26/610 "Bridge" series v1 https://lkml.org/lkml/2018/3/17/221 Peter Rosin (6): dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185 dt-bindings: display: atmel: optional video-interface of endpoints drm: of: introduce drm_of_media_bus_fmt drm/atmel-hlcdc: support bus-width (12/16/18/24) in endpoint nodes drm/atmel-hlcdc: add support for connecting to tda998x HDMI encoder drm/atmel-hlcdc: fix broken release date .../devicetree/bindings/display/atmel/hlcdc-dc.txt | 8 ++ .../bindings/display/bridge/lvds-transmitter.txt | 8 +- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 85 ++++++++++---- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 85 ++++++++++++-- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 15 +++ drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 130 +++++++++++++++++++++ drivers/gpu/drm/drm_of.c | 38 ++++++ include/drm/drm_of.h | 7 ++ 8 files changed, 347 insertions(+), 29 deletions(-) -- 2.11.0
next reply other threads:[~2018-04-17 13:11 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-17 13:10 Peter Rosin [this message] 2018-04-17 13:10 ` [PATCH v2 1/6] dt-bindings: display: bridge: lvds-transmitter: add ti,ds90c185 Peter Rosin 2018-04-17 13:10 ` [PATCH v2 2/6] dt-bindings: display: atmel: optional video-interface of endpoints Peter Rosin 2018-04-18 7:16 ` Boris Brezillon 2018-04-18 7:31 ` Peter Rosin 2018-04-18 8:29 ` Boris Brezillon 2018-04-17 13:10 ` [PATCH v2 3/6] drm: of: introduce drm_of_media_bus_fmt Peter Rosin 2018-04-19 16:22 ` Rob Herring 2018-04-19 16:40 ` Peter Rosin 2018-04-17 13:10 ` [PATCH v2 4/6] drm/atmel-hlcdc: support bus-width (12/16/18/24) in endpoint nodes Peter Rosin 2018-04-18 7:29 ` Boris Brezillon 2018-04-18 7:46 ` Peter Rosin 2018-04-18 8:27 ` Boris Brezillon 2018-04-17 13:10 ` [PATCH v2 5/6] drm/atmel-hlcdc: add support for connecting to tda998x HDMI encoder Peter Rosin 2018-04-18 7:36 ` Boris Brezillon 2018-04-18 8:02 ` Peter Rosin 2018-04-18 8:41 ` Boris Brezillon 2018-04-17 13:10 ` [PATCH v2 6/6] drm/atmel-hlcdc: fix broken release date Peter Rosin 2018-04-18 7:44 ` Boris Brezillon 2018-04-18 8:09 ` Peter Rosin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).