LKML Archive on
help / color / mirror / Atom feed
From: Souptick Joarder <>
Subject: [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t
Date: Tue, 17 Apr 2018 19:08:44 +0530	[thread overview]
Message-ID: <20180417133844.GA30256@jordon-HP-15-Notebook-PC> (raw)

Use new return type vm_fault_t for fault handler. For
now, this is just documenting that the function returns
a VM_FAULT value rather than an errno. Once all instances
are converted, vm_fault_t will become a distinct type.

Reference id -> 1c8f422059ae ("mm: change return type to

Signed-off-by: Souptick Joarder <>
 drivers/gpu/drm/qxl/qxl_ttm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/qxl/qxl_ttm.c b/drivers/gpu/drm/qxl/qxl_ttm.c
index 59cd74c..0b482b1 100644
--- a/drivers/gpu/drm/qxl/qxl_ttm.c
+++ b/drivers/gpu/drm/qxl/qxl_ttm.c
@@ -105,16 +105,16 @@ static void qxl_ttm_global_fini(struct qxl_device *qdev)
 static struct vm_operations_struct qxl_ttm_vm_ops;
 static const struct vm_operations_struct *ttm_vm_ops;
-static int qxl_ttm_fault(struct vm_fault *vmf)
+static vm_fault_t qxl_ttm_fault(struct vm_fault *vmf)
 	struct ttm_buffer_object *bo;
-	int r;
+	vm_fault_t ret;
 	bo = (struct ttm_buffer_object *)vmf->vma->vm_private_data;
 	if (bo == NULL)
 		return VM_FAULT_NOPAGE;
-	r = ttm_vm_ops->fault(vmf);
-	return r;
+	ret = ttm_vm_ops->fault(vmf);
+	return ret;
 int qxl_mmap(struct file *filp, struct vm_area_struct *vma)

             reply	other threads:[~2018-04-17 13:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 13:38 Souptick Joarder [this message]
2018-04-23 10:49 ` [PATCH] gpu: drm: qxl: Adding new typedef vm_fault_t Gerd Hoffmann
2018-04-24 12:11   ` Daniel Vetter
2018-04-24 12:35     ` Gerd Hoffmann
2018-05-10 15:21       ` Souptick Joarder
2018-05-14  9:02         ` Gerd Hoffmann
2018-05-14  9:15           ` Souptick Joarder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180417133844.GA30256@jordon-HP-15-Notebook-PC \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).