LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [RFC PATCH spi] spi: pxa2xx: pxa2xx_spi_transfer_one() can be static
  2018-04-17 19:53 [spi:for-4.18 12/12] drivers/spi/spi-pxa2xx.c:914:5: sparse: symbol 'pxa2xx_spi_transfer_one' was not declared. Should it be static? kbuild test robot
@ 2018-04-17 19:53 ` kbuild test robot
  2018-04-18  6:04   ` Jarkko Nikula
  2018-04-18 11:40   ` Applied "spi: pxa2xx: pxa2xx_spi_transfer_one() can be static" to the spi tree Mark Brown
  0 siblings, 2 replies; 4+ messages in thread
From: kbuild test robot @ 2018-04-17 19:53 UTC (permalink / raw)
  To: Jarkko Nikula
  Cc: kbuild-all, linux-spi, Mark Brown, Daniel Mack, Haojian Zhuang,
	Robert Jarzmik, linux-arm-kernel, linux-kernel


Fixes: d5898e19c0d7 ("spi: pxa2xx: Use core message processing loop")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 spi-pxa2xx.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index c852ea5..40f1346 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -911,9 +911,9 @@ static bool pxa2xx_spi_can_dma(struct spi_controller *master,
 	       xfer->len >= chip->dma_burst_size;
 }
 
-int pxa2xx_spi_transfer_one(struct spi_controller *master,
-			    struct spi_device *spi,
-			    struct spi_transfer *transfer)
+static int pxa2xx_spi_transfer_one(struct spi_controller *master,
+				   struct spi_device *spi,
+				   struct spi_transfer *transfer)
 {
 	struct driver_data *drv_data = spi_controller_get_devdata(master);
 	struct spi_message *message = master->cur_msg;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [spi:for-4.18 12/12] drivers/spi/spi-pxa2xx.c:914:5: sparse: symbol 'pxa2xx_spi_transfer_one' was not declared. Should it be static?
@ 2018-04-17 19:53 kbuild test robot
  2018-04-17 19:53 ` [RFC PATCH spi] spi: pxa2xx: pxa2xx_spi_transfer_one() can be static kbuild test robot
  0 siblings, 1 reply; 4+ messages in thread
From: kbuild test robot @ 2018-04-17 19:53 UTC (permalink / raw)
  To: Jarkko Nikula
  Cc: kbuild-all, linux-spi, Mark Brown, Daniel Mack, Haojian Zhuang,
	Robert Jarzmik, linux-arm-kernel, linux-kernel

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-4.18
head:   d5898e19c0d74cd41b9f5c8c8ea87e559c3fe0c1
commit: d5898e19c0d74cd41b9f5c8c8ea87e559c3fe0c1 [12/12] spi: pxa2xx: Use core message processing loop
reproduce:
        # apt-get install sparse
        git checkout d5898e19c0d74cd41b9f5c8c8ea87e559c3fe0c1
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   drivers/spi/spi-pxa2xx.c:877:16: sparse: expression using sizeof(void)
   drivers/spi/spi-pxa2xx.c:877:16: sparse: expression using sizeof(void)
>> drivers/spi/spi-pxa2xx.c:914:5: sparse: symbol 'pxa2xx_spi_transfer_one' was not declared. Should it be static?
   drivers/spi/spi-pxa2xx.c:1672:42: sparse: expression using sizeof(void)
   drivers/spi/spi-pxa2xx.c:1672:42: sparse: expression using sizeof(void)

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [RFC PATCH spi] spi: pxa2xx: pxa2xx_spi_transfer_one() can be static
  2018-04-17 19:53 ` [RFC PATCH spi] spi: pxa2xx: pxa2xx_spi_transfer_one() can be static kbuild test robot
@ 2018-04-18  6:04   ` Jarkko Nikula
  2018-04-18 11:40   ` Applied "spi: pxa2xx: pxa2xx_spi_transfer_one() can be static" to the spi tree Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Jarkko Nikula @ 2018-04-18  6:04 UTC (permalink / raw)
  To: kbuild test robot
  Cc: kbuild-all, linux-spi, Mark Brown, Daniel Mack, Haojian Zhuang,
	Robert Jarzmik, linux-arm-kernel, linux-kernel

On 04/17/18 22:53, kbuild test robot wrote:
> 
> Fixes: d5898e19c0d7 ("spi: pxa2xx: Use core message processing loop")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>   spi-pxa2xx.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
> index c852ea5..40f1346 100644
> --- a/drivers/spi/spi-pxa2xx.c
> +++ b/drivers/spi/spi-pxa2xx.c
> @@ -911,9 +911,9 @@ static bool pxa2xx_spi_can_dma(struct spi_controller *master,
>   	       xfer->len >= chip->dma_burst_size;
>   }
>   
> -int pxa2xx_spi_transfer_one(struct spi_controller *master,
> -			    struct spi_device *spi,
> -			    struct spi_transfer *transfer)
> +static int pxa2xx_spi_transfer_one(struct spi_controller *master,
> +				   struct spi_device *spi,
> +				   struct spi_transfer *transfer)

Thanks Fengguang. I don't understand how I managed to drop "static" 
while doing manual s/pump_transfers/pxa2xx_spi_transfer_one/ :-)

Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Applied "spi: pxa2xx: pxa2xx_spi_transfer_one() can be static" to the spi tree
  2018-04-17 19:53 ` [RFC PATCH spi] spi: pxa2xx: pxa2xx_spi_transfer_one() can be static kbuild test robot
  2018-04-18  6:04   ` Jarkko Nikula
@ 2018-04-18 11:40   ` Mark Brown
  1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2018-04-18 11:40 UTC (permalink / raw)
  To: kbuild test robot
  Cc: Fengguang Wu, Mark Brown, Jarkko Nikula, kbuild-all, linux-spi,
	Mark Brown, Daniel Mack, Haojian Zhuang, Robert Jarzmik,
	linux-arm-kernel, linux-kernel, linux-spi

The patch

   spi: pxa2xx: pxa2xx_spi_transfer_one() can be static

has been applied to the spi tree at

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From 71293a60e38f44b1d18c14803f0dd2744f6b9a12 Mon Sep 17 00:00:00 2001
From: kbuild test robot <lkp@intel.com>
Date: Wed, 18 Apr 2018 03:53:23 +0800
Subject: [PATCH] spi: pxa2xx: pxa2xx_spi_transfer_one() can be static

Fixes: d5898e19c0d7 ("spi: pxa2xx: Use core message processing loop")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 drivers/spi/spi-pxa2xx.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index c852ea5c28c6..40f1346b8188 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -911,9 +911,9 @@ static bool pxa2xx_spi_can_dma(struct spi_controller *master,
 	       xfer->len >= chip->dma_burst_size;
 }
 
-int pxa2xx_spi_transfer_one(struct spi_controller *master,
-			    struct spi_device *spi,
-			    struct spi_transfer *transfer)
+static int pxa2xx_spi_transfer_one(struct spi_controller *master,
+				   struct spi_device *spi,
+				   struct spi_transfer *transfer)
 {
 	struct driver_data *drv_data = spi_controller_get_devdata(master);
 	struct spi_message *message = master->cur_msg;
-- 
2.17.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-04-18 11:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-17 19:53 [spi:for-4.18 12/12] drivers/spi/spi-pxa2xx.c:914:5: sparse: symbol 'pxa2xx_spi_transfer_one' was not declared. Should it be static? kbuild test robot
2018-04-17 19:53 ` [RFC PATCH spi] spi: pxa2xx: pxa2xx_spi_transfer_one() can be static kbuild test robot
2018-04-18  6:04   ` Jarkko Nikula
2018-04-18 11:40   ` Applied "spi: pxa2xx: pxa2xx_spi_transfer_one() can be static" to the spi tree Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).