LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <email@example.com>
To: Nadav Amit <firstname.lastname@example.org>
Cc: Arnd Bergmann <email@example.com>,
Xavier Deguillard <firstname.lastname@example.org>,
Gil Kupfer <email@example.com>,
Oleksandr Natalenko <firstname.lastname@example.org>
Subject: Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is off
Date: Thu, 19 Apr 2018 08:38:56 +0200 [thread overview]
Message-ID: <20180419063856.GA7643@kroah.com> (raw)
On Wed, Apr 18, 2018 at 05:54:21PM +0000, Nadav Amit wrote:
> Oleksandr Natalenko <email@example.com> wrote:
> > Hello.
> > On Fri, Mar 23, 2018 at 9:42 AM, Oleksandr Natalenko
> > <firstname.lastname@example.org> wrote:
> >>> Actually, rechecking the bug description, I might have rushed. The bug that
> >>> I encountered is related to the vunmap() but it is only caused when batching
> >>> is off, while the bug you reported has batching on.
> >>> It seems that your sources support batching but do not include b91f108a3d54
> >>> (“VMware balloon: Treat init like reset”), which I think would have solved
> >>> the problem. I don’t see a mainline kernel that supports batching and does
> >>> not have this patch, so it would be helpful to see the exact module that you
> >>> use.
> >> Correct. The hash is d7568c130d0d0ff1fc5b364fc879b91f108a3d54, actually, though.
> >> Yes, we miss this commit in our code base, but also we've already
> >> provided a test kernel
> >> with this commit included to the customer. Unfortunately, we have no answer yet.
> > At least for one customer I can confirm that the kernel built with
> > both d7568c130 and the proposed patch fixes the issue.
> Can you commit please this patch? Preferably for 4.17?
> There is one minor mistake in the commit message - this patch fixes
> f220a80f0c2e and not as written. Please let me know if you want a v3 or can
> amend it while committing.
Please resend, never make a maintainer have to hand-edit a patch.
next prev parent reply other threads:[~2018-04-19 6:38 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 19:19 [PATCH] " Nadav Amit
2018-03-12 19:28 ` [PATCH v2] " Nadav Amit
2018-03-14 4:02 ` Nadav Amit
2018-03-14 7:41 ` Oleksandr Natalenko
2018-03-19 18:52 ` Nadav Amit
2018-03-20 7:21 ` Oleksandr Natalenko
2018-03-22 20:02 ` Nadav Amit
2018-03-23 8:42 ` Oleksandr Natalenko
2018-04-16 11:36 ` Oleksandr Natalenko
2018-04-18 17:54 ` Nadav Amit
2018-04-19 6:38 ` Greg Kroah-Hartman [this message]
2018-04-19 18:17 ` [PATCH v3] " Nadav Amit
2018-04-30 17:30 ` Nadav Amit
2018-05-04 11:26 ` Oleksandr Natalenko
2018-05-30 1:21 ` Nadav Amit
2018-05-31 20:56 ` Nadav Amit
2018-06-01 7:59 ` Greg Kroah-Hartman
2018-06-01 15:00 ` Nadav Amit
2018-06-01 7:47 ` [PATCH v3 RESEND] " Nadav Amit
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is off' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).