LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nadav Amit <namit@vmware.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Xavier Deguillard <xdeguillard@vmware.com>,
	pv-drivers <pv-drivers@vmware.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Gil Kupfer <gilkup@gmail.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"ldu@redhat.com" <ldu@redhat.com>,
	Oleksandr Natalenko <oleksandr@redhat.com>
Subject: Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is off
Date: Thu, 19 Apr 2018 08:38:56 +0200	[thread overview]
Message-ID: <20180419063856.GA7643@kroah.com> (raw)
In-Reply-To: <A518FF77-554C-40E0-8656-5BEFA57C7A8E@vmware.com>

On Wed, Apr 18, 2018 at 05:54:21PM +0000, Nadav Amit wrote:
> Oleksandr Natalenko <oleksandr@redhat.com> wrote:
> 
> > Hello.
> > 
> > On Fri, Mar 23, 2018 at 9:42 AM, Oleksandr Natalenko
> > <oleksandr@redhat.com> wrote:
> >>> Actually, rechecking the bug description, I might have rushed. The bug that
> >>> I encountered is related to the vunmap() but it is only caused when batching
> >>> is off, while the bug you reported has batching on.
> >>> 
> >>> It seems that your sources support batching but do not include b91f108a3d54
> >>> (“VMware balloon: Treat init like reset”), which I think would have solved
> >>> the problem. I don’t see a mainline kernel that supports batching and does
> >>> not have this patch, so it would be helpful to see the exact module that you
> >>> use.
> >> 
> >> Correct. The hash is d7568c130d0d0ff1fc5b364fc879b91f108a3d54, actually, though.
> >> Yes, we miss this commit in our code base, but also we've already
> >> provided a test kernel
> >> with this commit included to the customer. Unfortunately, we have no answer yet.
> > 
> > At least for one customer I can confirm that the kernel built with
> > both d7568c130 and the proposed patch fixes the issue.
> 
> Greg,
> 
> Can you commit please this patch? Preferably for 4.17?
> 
> There is one minor mistake in the commit message - this patch fixes
> f220a80f0c2e and not as written. Please let me know if you want a v3 or can
> amend it while committing.

Please resend, never make a maintainer have to hand-edit a patch.

thanks,

greg k-h

  reply	other threads:[~2018-04-19  6:38 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 19:19 [PATCH] " Nadav Amit
2018-03-12 19:28 ` [PATCH v2] " Nadav Amit
2018-03-14  4:02   ` Nadav Amit
2018-03-14  7:41     ` Oleksandr Natalenko
2018-03-19 18:52     ` Nadav Amit
2018-03-20  7:21       ` Oleksandr Natalenko
2018-03-22 20:02         ` Nadav Amit
2018-03-23  8:42           ` Oleksandr Natalenko
2018-04-16 11:36             ` Oleksandr Natalenko
2018-04-18 17:54               ` Nadav Amit
2018-04-19  6:38                 ` Greg Kroah-Hartman [this message]
2018-04-19 18:17                   ` [PATCH v3] " Nadav Amit
2018-04-30 17:30                     ` Nadav Amit
2018-05-04 11:26                       ` Oleksandr Natalenko
2018-05-30  1:21                       ` Nadav Amit
2018-05-31 20:56                         ` Nadav Amit
2018-06-01  7:59                           ` Greg Kroah-Hartman
2018-06-01 15:00                             ` Nadav Amit
2018-06-01  7:47                               ` [PATCH v3 RESEND] " Nadav Amit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180419063856.GA7643@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=gilkup@gmail.com \
    --cc=ldu@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namit@vmware.com \
    --cc=oleksandr@redhat.com \
    --cc=pv-drivers@vmware.com \
    --cc=stable@vger.kernel.org \
    --cc=xdeguillard@vmware.com \
    --subject='Re: [PATCH v2] vmw_balloon: fixing double free when batching mode is off' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).