LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* Some questions about cgroup aware OOM killer.
@ 2018-04-19  7:17 ufo19890607
  2018-04-19 10:43 ` Roman Gushchin
  0 siblings, 1 reply; 2+ messages in thread
From: ufo19890607 @ 2018-04-19  7:17 UTC (permalink / raw)
  To: guro, mhocko, vdavydov.dev, penguin-kernel, rientjes, akpm, tj
  Cc: kernel-team, cgroups, linux-kernel, linux-mm, yuzhoujian

From: yuzhoujian <yuzhoujian@didichuxing.com>

Hi Roman
I've read your patchset about cgroup aware OOM killer, and try
to merge your patchset to the upstream kernel(v4.17-rc1). But
I found some functions which in your patch([PATCH v13 3/7] 
mm, oom: cgroup-aware OOM killer) does not exist in the upstream
kernel. Which version of the kernel do you patch on? And, do you
have the latest patchset?

The faults in PATCH v13 3/7:
1. mm/oom_kill.o: In function `out_of_memory':
   /linux/mm/oom_kill.c:1125: undefined reference to `alloc_pages_before_oomkill'
2. mm/oom_kill.c: In function ‘out_of_memory’:
   mm/oom_kill.c:1125:5: error: ‘struct oom_control’ has no member named ‘page’
   oc->page = alloc_pages_before_oomkill(oc);
     ^

Best wishes

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: Some questions about cgroup aware OOM killer.
  2018-04-19  7:17 Some questions about cgroup aware OOM killer ufo19890607
@ 2018-04-19 10:43 ` Roman Gushchin
  0 siblings, 0 replies; 2+ messages in thread
From: Roman Gushchin @ 2018-04-19 10:43 UTC (permalink / raw)
  To: ufo19890607
  Cc: mhocko, vdavydov.dev, penguin-kernel, rientjes, akpm, tj,
	kernel-team, cgroups, linux-kernel, linux-mm, yuzhoujian

Hi!

Please, pull the whole patchset from the next tree:
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

$ git log next/master --oneline --author=guro@fb.com
1fecc970ac9e cgroup: list groupoom in cgroup features
dff73d397f7f mm-oom-docs-describe-the-cgroup-aware-oom-killer-fix
7cf83086511a mm, oom, docs: describe the cgroup-aware OOM killer
e2194b2869f1 mm, oom: add cgroup v2 mount option for cgroup-aware OOM killer
338fbcc52518 mm, oom: return error on access to memory.oom_group if groupoom is disabled
96fb32250ded mm, oom: introduce memory.oom_group
ed5f99985bf8 mm, oom: cgroup-aware OOM killer
e33eba2c3273 mm: implement mem_cgroup_scan_tasks() for the root memory cgroup
9bd3a4c529d4 mm, oom: refactor oom_kill_process()

Thanks!

On Thu, Apr 19, 2018 at 08:17:04AM +0100, ufo19890607 wrote:
> From: yuzhoujian <yuzhoujian@didichuxing.com>
> 
> Hi Roman
> I've read your patchset about cgroup aware OOM killer, and try
> to merge your patchset to the upstream kernel(v4.17-rc1). But
> I found some functions which in your patch([PATCH v13 3/7] 
> mm, oom: cgroup-aware OOM killer) does not exist in the upstream
> kernel. Which version of the kernel do you patch on? And, do you
> have the latest patchset?
> 
> The faults in PATCH v13 3/7:
> 1. mm/oom_kill.o: In function `out_of_memory':
>    /linux/mm/oom_kill.c:1125: undefined reference to `alloc_pages_before_oomkill'
> 2. mm/oom_kill.c: In function ‘out_of_memory’:
>    mm/oom_kill.c:1125:5: error: ‘struct oom_control’ has no member named ‘page’
>    oc->page = alloc_pages_before_oomkill(oc);
>      ^
> 
> Best wishes
> --
> To unsubscribe from this list: send the line "unsubscribe cgroups" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-19 10:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19  7:17 Some questions about cgroup aware OOM killer ufo19890607
2018-04-19 10:43 ` Roman Gushchin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).