LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drm/sun4i: Add missing frontend compatibles for A10, A13, A20 and A31
@ 2018-04-19 12:56 Paul Kocialkowski
  2018-04-19 15:07 ` Maxime Ripard
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Kocialkowski @ 2018-04-19 12:56 UTC (permalink / raw)
  To: dri-devel, linux-arm-kernel, linux-kernel, linux-sunxi
  Cc: Maxime Ripard, Chen-Yu Tsai, Paul Kocialkowski

Although frontend nodes are defined in the device-trees of the
aforementioned platforms, there are no matching compatibles defined in
the driver. This makes it impossible to probe the frontend on these
platforms.

Adding the appropriate compatibles to the driver fixes the issue.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
---
 drivers/gpu/drm/sun4i/sun4i_frontend.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/sun4i/sun4i_frontend.c b/drivers/gpu/drm/sun4i/sun4i_frontend.c
index 85f75046712c..c5a3de11817d 100644
--- a/drivers/gpu/drm/sun4i/sun4i_frontend.c
+++ b/drivers/gpu/drm/sun4i/sun4i_frontend.c
@@ -658,6 +658,10 @@ static const struct dev_pm_ops sun4i_frontend_pm_ops = {
 };
 
 const struct of_device_id sun4i_frontend_of_table[] = {
+	{ .compatible = "allwinner,sun7i-a10-display-frontend" },
+	{ .compatible = "allwinner,sun7i-a13-display-frontend" },
+	{ .compatible = "allwinner,sun7i-a20-display-frontend" },
+	{ .compatible = "allwinner,sun7i-a31-display-frontend" },
 	{ .compatible = "allwinner,sun8i-a33-display-frontend" },
 	{ }
 };
-- 
2.16.3

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/sun4i: Add missing frontend compatibles for A10, A13, A20 and A31
  2018-04-19 12:56 [PATCH] drm/sun4i: Add missing frontend compatibles for A10, A13, A20 and A31 Paul Kocialkowski
@ 2018-04-19 15:07 ` Maxime Ripard
  2018-04-20  7:33   ` Paul Kocialkowski
  0 siblings, 1 reply; 3+ messages in thread
From: Maxime Ripard @ 2018-04-19 15:07 UTC (permalink / raw)
  To: Paul Kocialkowski
  Cc: dri-devel, linux-arm-kernel, linux-kernel, linux-sunxi, Chen-Yu Tsai

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

On Thu, Apr 19, 2018 at 02:56:38PM +0200, Paul Kocialkowski wrote:
> Although frontend nodes are defined in the device-trees of the
> aforementioned platforms, there are no matching compatibles defined in
> the driver. This makes it impossible to probe the frontend on these
> platforms.
> 
> Adding the appropriate compatibles to the driver fixes the issue.
> 
> Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> ---
>  drivers/gpu/drm/sun4i/sun4i_frontend.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/sun4i/sun4i_frontend.c b/drivers/gpu/drm/sun4i/sun4i_frontend.c
> index 85f75046712c..c5a3de11817d 100644
> --- a/drivers/gpu/drm/sun4i/sun4i_frontend.c
> +++ b/drivers/gpu/drm/sun4i/sun4i_frontend.c
> @@ -658,6 +658,10 @@ static const struct dev_pm_ops sun4i_frontend_pm_ops = {
>  };
>  
>  const struct of_device_id sun4i_frontend_of_table[] = {
> +	{ .compatible = "allwinner,sun7i-a10-display-frontend" },
> +	{ .compatible = "allwinner,sun7i-a13-display-frontend" },
> +	{ .compatible = "allwinner,sun7i-a20-display-frontend" },
> +	{ .compatible = "allwinner,sun7i-a31-display-frontend" },

Most of these compatibles are wrong, so it won't really work :)

If you only tested it on the A20, just add it. We didn't add all of
them because there's some slight variations between the generations
that are not yet taken into account.

Maxime

-- 
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/sun4i: Add missing frontend compatibles for A10, A13, A20 and A31
  2018-04-19 15:07 ` Maxime Ripard
@ 2018-04-20  7:33   ` Paul Kocialkowski
  0 siblings, 0 replies; 3+ messages in thread
From: Paul Kocialkowski @ 2018-04-20  7:33 UTC (permalink / raw)
  To: Maxime Ripard
  Cc: dri-devel, linux-arm-kernel, linux-kernel, linux-sunxi, Chen-Yu Tsai

[-- Attachment #1: Type: text/plain, Size: 1863 bytes --]

Hi,

On Thu, 2018-04-19 at 17:07 +0200, Maxime Ripard wrote:
> On Thu, Apr 19, 2018 at 02:56:38PM +0200, Paul Kocialkowski wrote:
> > Although frontend nodes are defined in the device-trees of the
> > aforementioned platforms, there are no matching compatibles defined
> > in
> > the driver. This makes it impossible to probe the frontend on these
> > platforms.
> > 
> > Adding the appropriate compatibles to the driver fixes the issue.
> > 
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > ---
> >  drivers/gpu/drm/sun4i/sun4i_frontend.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/sun4i/sun4i_frontend.c
> > b/drivers/gpu/drm/sun4i/sun4i_frontend.c
> > index 85f75046712c..c5a3de11817d 100644
> > --- a/drivers/gpu/drm/sun4i/sun4i_frontend.c
> > +++ b/drivers/gpu/drm/sun4i/sun4i_frontend.c
> > @@ -658,6 +658,10 @@ static const struct dev_pm_ops
> > sun4i_frontend_pm_ops = {
> >  };
> >  
> >  const struct of_device_id sun4i_frontend_of_table[] = {
> > +	{ .compatible = "allwinner,sun7i-a10-display-frontend" },
> > +	{ .compatible = "allwinner,sun7i-a13-display-frontend" },
> > +	{ .compatible = "allwinner,sun7i-a20-display-frontend" },
> > +	{ .compatible = "allwinner,sun7i-a31-display-frontend" },
> 
> Most of these compatibles are wrong, so it won't really work :)

Sorry for screwing up so bad...

> If you only tested it on the A20, just add it. We didn't add all of
> them because there's some slight variations between the generations
> that are not yet taken into account.

That makes sense. I will thus send v2 with A20 only and send follow-up
patches for other platforms when tested and properly working.

Thanks!

-- 
Paul Kocialkowski, Bootlin (formerly Free Electrons)
Embedded Linux and kernel engineering
https://bootlin.com

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-04-20  7:35 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19 12:56 [PATCH] drm/sun4i: Add missing frontend compatibles for A10, A13, A20 and A31 Paul Kocialkowski
2018-04-19 15:07 ` Maxime Ripard
2018-04-20  7:33   ` Paul Kocialkowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).