LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lee Jones <lee.jones@linaro.org>,
	Jorge Eduardo Candelaria <jedu@slimlogic.co.uk>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] mfd: tps65911-comparator: Fix an off by one bug
Date: Thu, 19 Apr 2018 16:46:34 +0300	[thread overview]
Message-ID: <20180419134634.GA19793@mwanda> (raw)

The tps_comparators[] array is used in two places.  We only access the
COMP1 (1) and COMP2 (2) elements.  Unfortunately, we're accessing the
wrong elements and also one element beyond the end of the array.  There
was supposed to be a zero element at the start of the array which is
isn't accessed but makes the math work out nicely.

Fixes: 6851ad3ab346 ("TPS65911: Comparator: Add comparator driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
I can't actually compile this code...

diff --git a/drivers/mfd/tps65911-comparator.c b/drivers/mfd/tps65911-comparator.c
index c0789f81a1c5..35d7380f6fad 100644
--- a/drivers/mfd/tps65911-comparator.c
+++ b/drivers/mfd/tps65911-comparator.c
@@ -42,6 +42,7 @@ struct comparator {
 };
 
 static struct comparator tps_comparators[] = {
+	{	.name = "COMP", },
 	{
 		.name = "COMP1",
 		.reg = TPS65911_VMBCH,

             reply	other threads:[~2018-04-19 13:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 13:46 Dan Carpenter [this message]
2018-04-20  8:09 ` Lee Jones
2018-04-20  8:21   ` Dan Carpenter
2018-04-20  8:24     ` Dan Carpenter
2018-04-20  8:39     ` Lee Jones
2018-04-20  9:01       ` Dan Carpenter
2018-04-23  6:26         ` Lee Jones
2018-04-20  9:09       ` [PATCH v2] " Dan Carpenter
2018-04-23  6:44         ` Lee Jones
2018-04-23 10:27           ` Dan Carpenter
2018-04-24  5:45             ` Lee Jones
2018-04-20  8:59 ` [PATCH] " Dan Carpenter
2018-04-20  9:21   ` [PATCH] mfd: tps65911-comparator: Fix a build error Dan Carpenter
2018-04-23 18:13     ` Rhyland Klein
2018-04-24  5:46     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180419134634.GA19793@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=jedu@slimlogic.co.uk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] mfd: tps65911-comparator: Fix an off by one bug' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).