LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Mark Salter <msalter@redhat.com> To: "Frédéric Danis" <frederic.danis.oss@gmail.com> Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] ACPI / scan: Fix regression related to X-Gene UARTs Date: Thu, 19 Apr 2018 23:29:47 -0400 [thread overview] Message-ID: <20180420032947.23023-1-msalter@redhat.com> (raw) Commit e361d1f85855 ("ACPI / scan: Fix enumeration for special UART devices") caused a regression with some X-Gene based platforms (Mustang and M400) with invalid DSDT. The DSDT makes it appear that the UART device is also a slave device attached to itself. With the above commit the UART won't be enumerated by ACPI scan (slave serial devices shouldn't be). So check for X-Gene UART device and skip slace device check on it. Signed-off-by: Mark Salter <msalter@redhat.com> --- drivers/acpi/scan.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index cc234e6a6297..1dcdd0122862 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -1551,6 +1551,14 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device) fwnode_property_present(&device->fwnode, "baud"))) return true; + /* + * Firmware on some arm64 X-Gene platforms will make the UART + * device appear as both a UART and a slave of that UART. Just + * bail out here for X-Gene UARTs. + */ + if (!strcmp(acpi_device_hid(device), "APMC0D08")) + return false; + INIT_LIST_HEAD(&resource_list); acpi_dev_get_resources(device, &resource_list, acpi_check_serial_bus_slave, -- 2.14.3
next reply other threads:[~2018-04-20 3:30 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-20 3:29 Mark Salter [this message] 2018-04-22 9:34 ` [PATCH] ACPI / scan: Fix regression related to X-Gene UARTs Rafael J. Wysocki 2018-04-27 18:24 ` Mark Salter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180420032947.23023-1-msalter@redhat.com \ --to=msalter@redhat.com \ --cc=frederic.danis.oss@gmail.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=rjw@rjwysocki.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).