LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <email@example.com> To: Alexander Duyck <firstname.lastname@example.org> Cc: Bjorn Helgaas <email@example.com>, "Duyck, Alexander H" <firstname.lastname@example.org>, email@example.com, firstname.lastname@example.org, email@example.com, Netdev <firstname.lastname@example.org>, "Daly, Dan" <email@example.com>, LKML <firstname.lastname@example.org>, email@example.com, Keith Busch <firstname.lastname@example.org>, email@example.com, Don Dutile <firstname.lastname@example.org>, Maximilian Heyne <email@example.com>, "Wang, Liang-min" <firstname.lastname@example.org>, "Rustad, Mark D" <email@example.com>, David Woodhouse <firstname.lastname@example.org>, Christoph Hellwig <email@example.com>, firstname.lastname@example.org Subject: Re: [pci PATCH v7 0/5] Add support for unmanaged SR-IOV Date: Fri, 20 Apr 2018 03:46:46 +0300 [thread overview] Message-ID: <email@example.com> (raw) In-Reply-To: <CAKgT0UdTANRo3xnr89aWdfSPmMg81-W2H-ZcJUdC=5nUkf9RAw@mail.gmail.com> On Thu, Apr 19, 2018 at 03:54:49PM -0700, Alexander Duyck wrote: > On Thu, Mar 15, 2018 at 11:40 AM, Alexander Duyck > <firstname.lastname@example.org> wrote: > > This series is meant to add support for SR-IOV on devices when the VFs are > > not managed by the kernel. Examples of recent patches attempting to do this > > include: > > virto - https://patchwork.kernel.org/patch/10241225/ > > pci-stub - https://patchwork.kernel.org/patch/10109935/ > > vfio - https://patchwork.kernel.org/patch/10103353/ > > uio - https://patchwork.kernel.org/patch/9974031/ > > > > Since this is quickly blowing up into a multi-driver problem it is probably > > best to implement this solution as generically as possible. > > > > This series is an attempt to do that. What we do with this patch set is > > provide a generic framework to enable SR-IOV in the case that the PF driver > > doesn't support managing the VFs itself. > > > > I based my patch set originally on the patch by Mark Rustad but there isn't > > much left after going through and cleaning out the bits that were no longer > > needed, and after incorporating the feedback from David Miller. At this point > > the only items to be fully reused was his patch description which is now > > present in patch 3 of the set. > > > > This solution is limited in scope to just adding support for devices that > > provide no functionality for SR-IOV other than allocating the VFs by > > calling pci_enable_sriov. Previous sets had included patches for VFIO, but > > for now I am dropping that as the scope of that work is larger then I > > think I can take on at this time. > > > > v2: Reduced scope back to just virtio_pci and vfio-pci > > Broke into 3 patch set from single patch > > Changed autoprobe behavior to always set when num_vfs is set non-zero > > v3: Updated Documentation to clarify when sriov_unmanaged_autoprobe is used > > Wrapped vfio_pci_sriov_configure to fix build errors w/o SR-IOV in kernel > > v4: Dropped vfio-pci patch > > Added ena and nvme to drivers now using pci_sriov_configure_unmanaged > > Dropped pci_disable_sriov call in virtio_pci to be consistent with ena > > v5: Dropped sriov_unmanaged_autoprobe and pci_sriov_conifgure_unmanaged > > Added new patch that enables pci_sriov_configure_simple > > Updated drivers to use pci_sriov_configure_simple > > v6: Defined pci_sriov_configure_simple as NULL when SR-IOV is not enabled > > Updated drivers to drop "#ifdef" checks for IOV > > Added pci-pf-stub as place for PF-only drivers to add support > > v7: Dropped pci_id table explanation from pci-pf-stub driver > > Updated pci_sriov_configure_simple to drop need for err value > > Fixed comment explaining why pci_sriov_configure_simple is NULL > > > > Just following up since this has been sitting in patchwork for just > over a month now > (https://patchwork.ozlabs.org/project/linux-pci/list/?series=34034). > I'm just wondering what the expectation is on getting these pulled > into the pci tree? I'm assuming that is the best place for these > patches. Are there any concerns I still need to address or are these > going to be pulled in at some point, and if so is there any ETA on > when that will be? > > Thanks. > > - Alex Sorry I didn't notice you had more questions. I have responded hopefully explaining my concerns. Summary: - For virtio we should add this with a feature bit. - I am worried about security of this for the stub, but I am not the maintainer there. -- MST
next prev parent reply other threads:[~2018-04-20 0:46 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-15 18:40 [pci PATCH v7 0/5] Add support for unmanaged SR-IOV Alexander Duyck 2018-03-15 18:41 ` [pci PATCH v7 1/5] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources Alexander Duyck 2018-03-28 21:30 ` [virtio-dev] " Rustad, Mark D 2018-03-15 18:42 ` [pci PATCH v7 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices Alexander Duyck 2018-03-16 16:34 ` [virtio-dev] " Michael S. Tsirkin 2018-03-16 16:40 ` Alexander Duyck 2018-04-03 13:12 ` Michael S. Tsirkin 2018-04-03 17:32 ` Alexander Duyck 2018-04-03 18:27 ` Michael S. Tsirkin 2018-04-03 19:06 ` Alexander Duyck 2018-04-20 0:40 ` Michael S. Tsirkin 2018-04-20 14:56 ` Alexander Duyck 2018-04-20 15:28 ` Michael S. Tsirkin 2018-04-20 16:08 ` Alexander Duyck 2018-04-20 16:14 ` Michael S. Tsirkin 2018-04-21 7:05 ` Christoph Hellwig 2018-04-03 19:18 ` Rustad, Mark D 2018-03-28 21:31 ` Rustad, Mark D 2018-04-03 13:11 ` [virtio-dev] " Michael S. Tsirkin 2018-03-15 18:43 ` [pci PATCH v7 3/5] ena: Migrate over to unmanaged SR-IOV support Alexander Duyck 2018-03-15 18:43 ` [pci PATCH v7 4/5] nvme: " Alexander Duyck 2018-03-15 18:44 ` [pci PATCH v7 5/5] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs Alexander Duyck 2018-03-16 21:42 ` [pci PATCH v7 0/5] Add support for unmanaged SR-IOV Don Dutile 2018-04-19 22:54 ` Alexander Duyck 2018-04-20 0:46 ` Michael S. Tsirkin [this message] 2018-03-27 23:00 Alexander Duyck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).