From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753924AbeDTH27 (ORCPT ); Fri, 20 Apr 2018 03:28:59 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:44957 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753738AbeDTH25 (ORCPT ); Fri, 20 Apr 2018 03:28:57 -0400 X-Google-Smtp-Source: AIpwx4/tLYND98HsCUpPDRIlc7VPqd3hOJiC9EbpTor2l4rU8+3G0D/rYCO3OkRkpppXTBX4mpC+oQ== Date: Fri, 20 Apr 2018 09:28:54 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Kai-Heng Feng Cc: mjg59@srcf.ucam.org, dvhart@infradead.org, andy@infradead.org, mario.limonciello@dell.com, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events Message-ID: <20180420072854.bprouoj5poim5rxv@pali> References: <20180420072648.5426-1-kai.heng.feng@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180420072648.5426-1-kai.heng.feng@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 20 April 2018 15:26:48 Kai-Heng Feng wrote: > There are two new events generated by dell-wmi, rfkill and fn-lock, from > Dell Systems. > > When Fn-lock hotkey gets pressed to switch to function mode: > [85951.591542] dell_wmi: Unknown key with type 0x0010 and code 0xe035 > pressed > [85951.591546] dell_wmi: Unknown key with type 0x0010 and code 0x0000 > pressed > > When Fn-lock hotkey gets pressed to switch to multimedia mode: > [85956.667686] dell_wmi: Unknown key with type 0x0010 and code 0xe035 > pressed > [85956.667690] dell_wmi: Unknown key with type 0x0010 and code 0x0001 > pressed > > When radio hotkey gets pressed: > [85974.430220] dell_wmi: Unknown key with type 0x0010 and code 0xe008 > pressed > > These events are for notification purpose, so we can ignore them. > > This patch is tested on XPS 9370. > > Signed-off-by: Kai-Heng Feng Reviewed-by: Pali Rohár > --- > v2: Reorder alphabetically. > More detailed changelog. > > drivers/platform/x86/dell-wmi.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > index 8d102195a392..ba8e6725d7ac 100644 > --- a/drivers/platform/x86/dell-wmi.c > +++ b/drivers/platform/x86/dell-wmi.c > @@ -261,6 +261,12 @@ static const u16 bios_to_linux_keycode[256] = { > * override them. > */ > static const struct key_entry dell_wmi_keymap_type_0010[] = { > + /* Fn-lock switched to function keys */ > + { KE_IGNORE, 0x0, { KEY_RESERVED } }, > + > + /* Fn-lock switched to multimedia keys */ > + { KE_IGNORE, 0x1, { KEY_RESERVED } }, > + > /* Mic mute */ > { KE_KEY, 0x150, { KEY_MICMUTE } }, > > @@ -296,6 +302,14 @@ static const struct key_entry dell_wmi_keymap_type_0010[] = { > { KE_KEY, 0x851, { KEY_PROG2 } }, > { KE_KEY, 0x852, { KEY_PROG3 } }, > > + /* > + * Radio disable (notify only -- there is no model for which the > + * WMI event is supposed to trigger an action). > + */ > + { KE_IGNORE, 0xe008, { KEY_RFKILL } }, > + > + /* Fn-lock */ > + { KE_IGNORE, 0xe035, { KEY_RESERVED } }, > }; > > /* -- Pali Rohár pali.rohar@gmail.com