LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org,
	willy@infradead.org
Subject: Re: [PATCH] kernel: event: core: Change return type to vm_fault_t
Date: Fri, 20 Apr 2018 10:28:29 +0200	[thread overview]
Message-ID: <20180420082829.GE4064@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20180414202831.GA20373@jordon-HP-15-Notebook-PC>

On Sun, Apr 15, 2018 at 01:58:31AM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler and
> page_mkwrite handler in struct vm_operations_struct.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com>
> ---
>  kernel/events/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 96db9ae..d09f1c4 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -4918,11 +4918,11 @@ void perf_event_update_userpage(struct perf_event *event)
>  }
>  EXPORT_SYMBOL_GPL(perf_event_update_userpage);
> 
> -static int perf_mmap_fault(struct vm_fault *vmf)
> +static vm_fault_t perf_mmap_fault(struct vm_fault *vmf)

I'm fine with the patch, but shouldn't this be part of a larger series /
cocinelle script?

Even if not everything that has a (struct vm_fault *) argument is a
fault handler, you could still match on the function being assigned to
vm_operations_struct::fault.

So ACK on the patch, but please don't do this with a slow trickle of
individual patches.

  reply	other threads:[~2018-04-20  8:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-14 20:28 Souptick Joarder
2018-04-20  8:28 ` Peter Zijlstra [this message]
2018-04-20 11:48   ` Souptick Joarder
2018-05-10 14:24     ` Souptick Joarder
2018-05-17 14:25       ` Souptick Joarder
2018-05-17 14:27         ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180420082829.GE4064@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=acme@kernel.org \
    --cc=jrdr.linux@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH] kernel: event: core: Change return type to vm_fault_t' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).