From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754200AbeDTIgV (ORCPT ); Fri, 20 Apr 2018 04:36:21 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:49784 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753957AbeDTIgU (ORCPT ); Fri, 20 Apr 2018 04:36:20 -0400 Date: Fri, 20 Apr 2018 10:36:07 +0200 From: Peter Zijlstra To: Vince Weaver Cc: Jiri Olsa , Stephane Eranian , LKML , Arnaldo Carvalho de Melo , mingo@elte.hu, Andi Kleen Subject: Re: [RFC] perf/core: what is exclude_idle supposed to do Message-ID: <20180420083607.GG4064@hirez.programming.kicks-ass.net> References: <20180417062010.GA2052@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 18, 2018 at 11:10:20AM -0400, Vince Weaver wrote: > On Tue, 17 Apr 2018, Jiri Olsa wrote: > > > On Mon, Apr 16, 2018 at 10:04:53PM +0000, Stephane Eranian wrote: > > > Hi, > > > > > > I am trying to understand what the exclude_idle event attribute is supposed > > > to accomplish. > > > As per the definition in the header file: > > > > > > exclude_idle : 1, /* don't count when idle */ > > > > AFAICS it's not implemented > > so just to be completely clear hear, we're saying that the "exclude_idle" > modifier has never done anything useful and still doesn't? AFAICT it works on Power and possibly ARM.