LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Lee Jones <lee.jones@linaro.org>, Rhyland Klein <rklein@nvidia.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] mfd: tps65911-comparator: Fix a build error
Date: Fri, 20 Apr 2018 12:21:05 +0300	[thread overview]
Message-ID: <20180420092105.GA28058@mwanda> (raw)
In-Reply-To: <20180420085938.ymf2jc46dswylxh4@mwanda>

In 2012, we changed the tps65910 API and fixed most drivers but forgot
to update this one.

Fixes: 3f7e82759c69 ("mfd: Commonize tps65910 regmap access through header")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/mfd/tps65911-comparator.c b/drivers/mfd/tps65911-comparator.c
index 887409c3938d..90cfdd1f88c6 100644
--- a/drivers/mfd/tps65911-comparator.c
+++ b/drivers/mfd/tps65911-comparator.c
@@ -74,7 +74,7 @@ static int comp_threshold_set(struct tps65910 *tps65910, int id, int voltage)
 		return -EINVAL;
 
 	val = index << 1;
-	ret = tps65910->write(tps65910, tps_comp.reg, 1, &val);
+	ret = tps65910_reg_write(tps65910, tps_comp.reg, val);
 
 	return ret;
 }
@@ -82,10 +82,10 @@ static int comp_threshold_set(struct tps65910 *tps65910, int id, int voltage)
 static int comp_threshold_get(struct tps65910 *tps65910, int id)
 {
 	struct comparator tps_comp = tps_comparators[id - 1];
+	unsigned int val;
 	int ret;
-	u8 val;
 
-	ret = tps65910->read(tps65910, tps_comp.reg, 1, &val);
+	ret = tps65910_reg_read(tps65910, tps_comp.reg, &val);
 	if (ret < 0)
 		return ret;
 

  reply	other threads:[~2018-04-20  9:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 13:46 [PATCH] mfd: tps65911-comparator: Fix an off by one bug Dan Carpenter
2018-04-20  8:09 ` Lee Jones
2018-04-20  8:21   ` Dan Carpenter
2018-04-20  8:24     ` Dan Carpenter
2018-04-20  8:39     ` Lee Jones
2018-04-20  9:01       ` Dan Carpenter
2018-04-23  6:26         ` Lee Jones
2018-04-20  9:09       ` [PATCH v2] " Dan Carpenter
2018-04-23  6:44         ` Lee Jones
2018-04-23 10:27           ` Dan Carpenter
2018-04-24  5:45             ` Lee Jones
2018-04-20  8:59 ` [PATCH] " Dan Carpenter
2018-04-20  9:21   ` Dan Carpenter [this message]
2018-04-23 18:13     ` [PATCH] mfd: tps65911-comparator: Fix a build error Rhyland Klein
2018-04-24  5:46     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180420092105.GA28058@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rklein@nvidia.com \
    --subject='Re: [PATCH] mfd: tps65911-comparator: Fix a build error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).