LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Rodrigo Vivi <firstname.lastname@example.org>
To: Jani Nikula <email@example.com>
Cc: "Srivatsa, Anusha" <firstname.lastname@example.org>,
Ian W MORRISON <email@example.com>,
Greg KH <firstname.lastname@example.org>,
"Wajdeczko, Michal" <Michal.Wajdeczko@intel.com>
Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake
Date: Fri, 20 Apr 2018 11:03:32 -0700 [thread overview]
Message-ID: <20180420180331.GE3304@intel.com> (raw)
On Tue, Apr 17, 2018 at 12:02:52PM +0300, Jani Nikula wrote:
> On Mon, 16 Apr 2018, "Srivatsa, Anusha" <email@example.com> wrote:
> >>-----Original Message-----
> >>From: Jani Nikula [mailto:firstname.lastname@example.org]
> >>Sent: Wednesday, April 11, 2018 5:27 AM
> >>To: Ian W MORRISON <email@example.com>
> >>Cc: Vivi, Rodrigo <firstname.lastname@example.org>; Srivatsa, Anusha
> >><email@example.com>; Wajdeczko, Michal
> >><Michal.Wajdeczko@intel.com>; Greg KH <firstname.lastname@example.org>;
> >>email@example.com; firstname.lastname@example.org; email@example.com;
> >>firstname.lastname@example.org; email@example.com; dri-
> >>Subject: Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for
> >>On Wed, 11 Apr 2018, Ian W MORRISON <firstname.lastname@example.org> wrote:
> >>> <snip>
> >>>> NAK on indiscriminate Cc: stable. There are zero guarantees that
> >>>> older kernels will work with whatever firmware you throw at them.
> >>> I included 'Cc: stable' so the patch would get added to the v4.16 and
> >>> v4.15 kernels which I have tested with the patch. I found that earlier
> >>> kernels didn't support the 'linux-firmware' package required to get
> >>> wifi working on Intel's new Gemini Lake NUC.
> >>You realize that this patch should have nothing to do with wifi?
> >>Rodrigo, Anusha, if you think Cc: stable is appropriate, please indicate the specific
> >>versions of stable it is appropriate for.
> > Hi Jani,
> > The stable kernel version is 4.12 and beyond.
> > It is appropriate to add the CC: stable in my opinion
> Who tested the firmware with v4.12 and later? We only have the CI
> results against *current* drm-tip. We don't even know about v4.16.
I understand your concerns, but the problem was that our old process
was a bit (lot?) messed and there was the unreliable time
until the firmware really lands on linux-firmware.git. So MODULE_FIRMWARE
call was only added after firmware was really there on firmware repository
but it wasn't about the testing.
In other words, the bump version patch was merged after tested, but
MODULE_FIRMWARE was left behind because firmware blob took a while to get
pulled into linux-firmware.git and we end up forgetting to add it there.
In my opinion it should be safe to add the MODULE_FIRMWARE there
based on the tests from when the version was bumped.
> I'm not going to ack and take responsibility for the stable backports
> unless someone actually comes forward with credible Tested-bys.
> > Anusha
> >>>> PS. How is this a "RESEND"? I haven't seen this before.
> >>> It is a 'RESEND' for that very reason. I initially sent the patch to
> >>> the same people as a similar patch
> >>> (https://patchwork.kernel.org/patch/10143637/) however after realising
> >>> this omitted required addresses I added them and resent the patch.
> >>> Best regards,
> >>> Ian
> >>Jani Nikula, Intel Open Source Technology Center
> Jani Nikula, Intel Open Source Technology Center
> dri-devel mailing list
next prev parent reply other threads:[~2018-04-20 18:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-11 4:42 ianwmorrison
2018-04-11 9:24 ` Jani Nikula
2018-04-11 10:41 ` Ian W MORRISON
2018-04-11 12:27 ` Jani Nikula
2018-04-11 13:04 ` Ian W MORRISON
2018-04-16 22:47 ` Srivatsa, Anusha
2018-04-17 9:02 ` Jani Nikula
2018-04-17 14:14 ` Joonas Lahtinen
2018-04-20 5:47 ` Ian W MORRISON
2018-04-20 7:50 ` Jani Nikula
2018-04-20 8:25 ` Ian W MORRISON
2018-04-20 18:03 ` Rodrigo Vivi [this message]
2018-04-20 18:30 ` Srivatsa, Anusha
2018-04-21 1:22 ` Botello Ortega, Luis
2018-04-21 22:46 ` Ian W MORRISON
2018-04-25 23:15 ` Ian W MORRISON
2018-04-27 9:20 ` Jani Nikula
2018-04-30 7:58 ` Joonas Lahtinen
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--subject='Re: [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake' \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).