LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Jean-Jacques Hiblot <jjhiblot@ti.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, perex@perex.cz,
	tiwai@suse.com, dannenberg@ti.com, afd@ti.com,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ASoC: tas6424: Add support for the mute pin
Date: Mon, 23 Apr 2018 16:37:46 +0100	[thread overview]
Message-ID: <20180423153746.GJ19834@sirena.org.uk> (raw)
In-Reply-To: <1524218684-19752-4-git-send-email-jjhiblot@ti.com>

[-- Attachment #1: Type: text/plain, Size: 715 bytes --]

On Fri, Apr 20, 2018 at 12:04:44PM +0200, Jean-Jacques Hiblot wrote:

> +	- mute-gpio: GPIO used to mute all the outputs

Same thing with the plural here.

> +	if (tas6424->mute_gpio) {
> +		gpiod_set_value_cansleep(tas6424->mute_gpio, mute ? 1 : 0);
> +		return 0;
> +	}

Just use mute directly, the ternery operator is doing nothing for
legibility here and C does the integer to boolean thing for you.

> +	if (tas6424->mute_gpio) {
> +		gpiod_set_value_cansleep(tas6424->mute_gpio, 0);
> +		/*
> +		 * channels are muted via the mute pin, don't also. Don't also
> +		 * mute them via the registers so that subsequent register
> +		 * access is not necessary to un-mute the channels

Extra "don't also" in there.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

      reply	other threads:[~2018-04-23 15:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-20 10:04 [PATCH 0/3] ASoc: TAS6424: Add support for mute, standby, and faster power on Jean-Jacques Hiblot
2018-04-20 10:04 ` [PATCH 1/3] ASoC: tas6424: Allow disabling auto diagnostics for faster power-on Jean-Jacques Hiblot
2018-04-23 15:44   ` Mark Brown
2018-04-23 19:00     ` Jean-Jacques Hiblot
2018-04-24 10:19       ` Mark Brown
2018-04-20 10:04 ` [PATCH 2/3] ASoC: tas6424: Add support for the standby pin Jean-Jacques Hiblot
2018-04-23 15:35   ` Mark Brown
2018-04-20 10:04 ` [PATCH 3/3] ASoC: tas6424: Add support for the mute pin Jean-Jacques Hiblot
2018-04-23 15:37   ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180423153746.GJ19834@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=afd@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dannenberg@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jjhiblot@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=perex@perex.cz \
    --cc=robh+dt@kernel.org \
    --cc=tiwai@suse.com \
    --subject='Re: [PATCH 3/3] ASoC: tas6424: Add support for the mute pin' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).