LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: xswang@marvell.com
Cc: linux-ide@vger.kernel.org, tj@kernel.org,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	oferh@marvell.com, dingwei@marvell.com, xigu@marvell.com,
	nadavh@marvell.com,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 2/2] ata: ahci: mvebu: override ahci_stop_engine for mvebu AHCI
Date: Tue, 24 Apr 2018 08:22:46 +0200	[thread overview]
Message-ID: <20180424062246.GB14537@kroah.com> (raw)
In-Reply-To: <1524542805-11349-3-git-send-email-xswang@marvell.com>

On Tue, Apr 24, 2018 at 12:06:45PM +0800, xswang@marvell.com wrote:
> From: Evan Wang <xswang@marvell.com>
> 
> There is an issue(Errata Ref#226) that the SATA can not be
> detected via SATA Port-MultiPlayer(PMP) with following
> error log:
>   ata1.15: PMP product ID mismatch
>   ata1.15: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
>   ata1.15: Port Multiplier vendor mismatch '0x1b4b'!='0x0'
>   ata1.15: PMP revalidation failed (errno=-19)
> 
> After debugging, the reason is found that the value Port-x
> FIS-based Switching Control(PxFBS@0x40) become wrong.
> According to design, the bits[11:8, 0] of register PxFBS
> are cleared when Port Command and Status (0x18) bit[0]
> changes its value from 1 to 0, i.e. falling edge of Port
> Command and Status bit[0] sends PULSE that resets PxFBS
> bits[11:8; 0].
> So it needs a mvebu SATA WA to save the port PxFBS register
> before PxCMD ST write and restore it afterwards.
> 
> This patch implements the WA in a separate function of
> ahci_mvebu_stop_engine to override ahci_stop_gngine.
> 
> Signed-off-by: Evan Wang <xswang@marvell.com>
> Suggested-by: Ofer Heifetz <oferh@marvell.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  drivers/ata/ahci_mvebu.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 56 insertions(+)


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

  reply	other threads:[~2018-04-24  6:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24  4:06 [PATCH 0/2] Allow drivers to override stop_engine xswang
2018-04-24  4:06 ` [PATCH 1/2] libahci: " xswang
2018-04-24  6:22   ` Greg KH
2018-04-24  4:06 ` [PATCH 2/2] ata: ahci: mvebu: override ahci_stop_engine for mvebu AHCI xswang
2018-04-24  6:22   ` Greg KH [this message]
2018-04-25  4:27 [PATCH 0/2] Allow drivers to override stop_engine xswang
2018-04-25  4:27 ` [PATCH 2/2] ata: ahci: mvebu: override ahci_stop_engine for mvebu AHCI xswang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424062246.GB14537@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dingwei@marvell.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nadavh@marvell.com \
    --cc=oferh@marvell.com \
    --cc=stable@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tj@kernel.org \
    --cc=xigu@marvell.com \
    --cc=xswang@marvell.com \
    --subject='Re: [PATCH 2/2] ata: ahci: mvebu: override ahci_stop_engine for mvebu AHCI' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).