LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: jack@suse.cz, Al Viro <viro@zeniv.linux.org.uk>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Michal Hocko <mhocko@suse.com>,
	kirill.shutemov@linux.intel.com,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linux-MM <linux-mm@kvack.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] fs: dax: Adding new return type vm_fault_t
Date: Tue, 24 Apr 2018 04:45:17 -0700	[thread overview]
Message-ID: <20180424114517.GC26636@bombadil.infradead.org> (raw)
In-Reply-To: <CAFqt6zatfzk8PmBN110LD_x8goU+vO4U9TAGaamJ4UqwRm+g_g@mail.gmail.com>

On Tue, Apr 24, 2018 at 11:29:39AM +0530, Souptick Joarder wrote:
> On Tue, Apr 24, 2018 at 1:19 AM, Matthew Wilcox <willy@infradead.org> wrote:
> > On Mon, Apr 23, 2018 at 11:36:25PM +0530, Souptick Joarder wrote:
> >> If the insertion of PTE failed because someone else
> >> already added a different entry in the mean time, we
> >> treat that as success as we assume the same entry was
> >> actually inserted.
> >
> > No, Jan said to *make it a comment*.  In the source file.  That's why
> > he formatted it with the /* */.  Not in the changelog.
> Sorry, got confused.
> 
> I think this should be fine -
> 
> +/*
> +If the insertion of PTE failed because someone else
> +already added a different entry in the mean time, we
> +treat that as success as we assume the same entry was
> +actually inserted.
> +*/

Jan literally typed out exactly what you need to insert:

/*
 * If the insertion of PTE failed because someone else already added a
 * different entry in the mean time, we treat that as success as we assume
 * the same entry was actually inserted.
 */

For some reason you've chosen to wrap the lines shorter than Jan had them,
and use a different comment formatting style from the rest of the kernel.
Why?  I'd suggest re-reading Documentation/process/coding-style.rst

      reply	other threads:[~2018-04-24 11:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 18:06 Souptick Joarder
2018-04-23 19:49 ` Matthew Wilcox
2018-04-24  5:59   ` Souptick Joarder
2018-04-24 11:45     ` Matthew Wilcox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424114517.GC26636@bombadil.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=dan.j.williams@intel.com \
    --cc=jack@suse.cz \
    --cc=jrdr.linux@gmail.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=ross.zwisler@linux.intel.com \
    --cc=viro@zeniv.linux.org.uk \
    --subject='Re: [PATCH v5] fs: dax: Adding new return type vm_fault_t' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).