LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drdb: fix print_st_err()'s prototype
@ 2018-04-24 13:14 Luc Van Oostenryck
  2018-04-25 10:54 ` [Drbd-dev] " Roland Kammerer
  0 siblings, 1 reply; 2+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:14 UTC (permalink / raw)
  To: linux-kernel
  Cc: Luc Van Oostenryck, Philipp Reisner, Lars Ellenberg, Jens Axboe,
	drbd-dev, linux-block

print_st_err() is defined with its 4th argument taking an
'enum drbd_state_rv' but its prototype use an int for it.

Fix this by using 'enum drbd_state_rv' in the prototype too.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 drivers/block/drbd/drbd_state.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/drbd/drbd_state.h b/drivers/block/drbd/drbd_state.h
index ea58301d0..b2a390ba7 100644
--- a/drivers/block/drbd/drbd_state.h
+++ b/drivers/block/drbd/drbd_state.h
@@ -131,7 +131,7 @@ extern enum drbd_state_rv _drbd_set_state(struct drbd_device *, union drbd_state
 					  enum chg_state_flags,
 					  struct completion *done);
 extern void print_st_err(struct drbd_device *, union drbd_state,
-			union drbd_state, int);
+			union drbd_state, enum drbd_state_rv);
 
 enum drbd_state_rv
 _conn_request_state(struct drbd_connection *connection, union drbd_state mask, union drbd_state val,
-- 
2.17.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Drbd-dev] [PATCH] drdb: fix print_st_err()'s prototype
  2018-04-24 13:14 [PATCH] drdb: fix print_st_err()'s prototype Luc Van Oostenryck
@ 2018-04-25 10:54 ` Roland Kammerer
  0 siblings, 0 replies; 2+ messages in thread
From: Roland Kammerer @ 2018-04-25 10:54 UTC (permalink / raw)
  To: Luc Van Oostenryck
  Cc: linux-kernel, Jens Axboe, Philipp Reisner, linux-block,
	Lars Ellenberg, drbd-dev

On Tue, Apr 24, 2018 at 03:14:10PM +0200, Luc Van Oostenryck wrote:
> print_st_err() is defined with its 4th argument taking an
> 'enum drbd_state_rv' but its prototype use an int for it.
> 
> Fix this by using 'enum drbd_state_rv' in the prototype too.
> 
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
>  drivers/block/drbd/drbd_state.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/drbd/drbd_state.h b/drivers/block/drbd/drbd_state.h
> index ea58301d0..b2a390ba7 100644
> --- a/drivers/block/drbd/drbd_state.h
> +++ b/drivers/block/drbd/drbd_state.h
> @@ -131,7 +131,7 @@ extern enum drbd_state_rv _drbd_set_state(struct drbd_device *, union drbd_state
>  					  enum chg_state_flags,
>  					  struct completion *done);
>  extern void print_st_err(struct drbd_device *, union drbd_state,
> -			union drbd_state, int);
> +			union drbd_state, enum drbd_state_rv);
>  
>  enum drbd_state_rv
>  _conn_request_state(struct drbd_connection *connection, union drbd_state mask, union drbd_state val,
> -- 
> 2.17.0

Thanks, looks good.

Applied to our internal tree. As usual, we send it mainline bundled with
other pending changes.

Regards, rck

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-25 10:54 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:14 [PATCH] drdb: fix print_st_err()'s prototype Luc Van Oostenryck
2018-04-25 10:54 ` [Drbd-dev] " Roland Kammerer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).