LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drm/bridge: adv7511: fix mode_valid's return type
@ 2018-04-24 13:14 Luc Van Oostenryck
2018-04-25 7:08 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:14 UTC (permalink / raw)
To: linux-kernel
Cc: Luc Van Oostenryck, Archit Taneja, Andrzej Hajda,
Laurent Pinchart, David Airlie, Lars-Peter Clausen,
Bhumika Goyal, Shawn Guo, Hans Verkuil, Inki Dae, Daniel Vetter,
dri-devel
The method struct drm_connector_helper_funcs::mode_valid is defined
as returning an 'enum drm_mode_status' but the driver implementation
for this method uses an 'int' for it.
Fix this by using 'enum drm_mode_status' in the driver too.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index efa29db5f..1b74ee00b 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -654,7 +654,7 @@ adv7511_detect(struct adv7511 *adv7511, struct drm_connector *connector)
return status;
}
-static int adv7511_mode_valid(struct adv7511 *adv7511,
+static enum drm_mode_status adv7511_mode_valid(struct adv7511 *adv7511,
struct drm_display_mode *mode)
{
if (mode->clock > 165000)
--
2.17.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/bridge: adv7511: fix mode_valid's return type
2018-04-24 13:14 [PATCH] drm/bridge: adv7511: fix mode_valid's return type Luc Van Oostenryck
@ 2018-04-25 7:08 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2018-04-25 7:08 UTC (permalink / raw)
To: Luc Van Oostenryck
Cc: linux-kernel, Archit Taneja, Andrzej Hajda, Laurent Pinchart,
David Airlie, Lars-Peter Clausen, Bhumika Goyal, Shawn Guo,
Hans Verkuil, Inki Dae, Daniel Vetter, dri-devel
On Tue, Apr 24, 2018 at 03:14:47PM +0200, Luc Van Oostenryck wrote:
> The method struct drm_connector_helper_funcs::mode_valid is defined
> as returning an 'enum drm_mode_status' but the driver implementation
> for this method uses an 'int' for it.
>
> Fix this by using 'enum drm_mode_status' in the driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
Applied to drm-misc-next.
-Daniel
> ---
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index efa29db5f..1b74ee00b 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -654,7 +654,7 @@ adv7511_detect(struct adv7511 *adv7511, struct drm_connector *connector)
> return status;
> }
>
> -static int adv7511_mode_valid(struct adv7511 *adv7511,
> +static enum drm_mode_status adv7511_mode_valid(struct adv7511 *adv7511,
> struct drm_display_mode *mode)
> {
> if (mode->clock > 165000)
> --
> 2.17.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-25 7:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:14 [PATCH] drm/bridge: adv7511: fix mode_valid's return type Luc Van Oostenryck
2018-04-25 7:08 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).