LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Stefan Potyra <Stefan.Potyra@elektrobit.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: Mark Brown <broonie@kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
<bcm-kernel-feedback-list@broadcom.com>,
<linux-spi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Jonas Gorski <jonas.gorski@gmail.com>,
<ldv-project@linuxtesting.org>, <sil2review@lists.osadl.org>
Subject: [PATCH v2] spi/bcm63xx-hspi: Enable the clock before calling clk_get_rate().
Date: Tue, 24 Apr 2018 18:16:05 +0200 [thread overview]
Message-ID: <20180424161605.GA17825@er01809n.ebgroup.elektrobit.com> (raw)
In-Reply-To: <dfb9c72c-6289-a2ea-c3d4-c59f5e3c799c@broadcom.com>
Enable the clock prior to calling clk_get_rate(), because clk_get_rate()
should only be called if the clock is enabled.
Found by Linux Driver Verification project (linuxtesting.org).
Fixes: 142168eba9dc (spi: "bcm63xx-hsspi: add bcm63xx HSSPI driver")
Signed-off-by: Stefan Potyra <Stefan.Potyra@elektrobit.com>
---
drivers/spi/spi-bcm63xx-hsspi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c
index cbcba614b253..46cd9b683d22 100644
--- a/drivers/spi/spi-bcm63xx-hsspi.c
+++ b/drivers/spi/spi-bcm63xx-hsspi.c
@@ -352,6 +352,10 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)
if (IS_ERR(clk))
return PTR_ERR(clk);
+ ret = clk_prepare_enable(clk);
+ if (ret)
+ return ret;
+
rate = clk_get_rate(clk);
if (!rate) {
struct clk *pll_clk = devm_clk_get(dev, "pll");
@@ -364,10 +368,6 @@ static int bcm63xx_hsspi_probe(struct platform_device *pdev)
return -EINVAL;
}
- ret = clk_prepare_enable(clk);
- if (ret)
- return ret;
-
master = spi_alloc_master(&pdev->dev, sizeof(*bs));
if (!master) {
ret = -ENOMEM;
--
2.17.0
next prev parent reply other threads:[~2018-04-24 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 13:03 [PATCH] " Stefan Potyra
2018-04-21 23:10 ` Florian Fainelli
2018-04-24 16:16 ` Stefan Potyra [this message]
2018-04-24 17:32 ` [PATCH v2] spi/bcm63xx-hspi: " Mark Brown
2018-04-25 13:47 ` [PATCH v3] spi/bcm63xx-hspi: Enable the clock before calling Stefan Potyra
2018-04-25 15:50 ` Mark Brown
2018-04-25 16:49 ` [PATCH v4] spi/bcm63xx-hspi: Enable the clock before calling clk_get_rate() Stefan Potyra
2018-04-25 17:28 ` Mark Brown
2018-04-26 7:28 ` [PATCH v5] " Stefan Potyra
2018-04-26 11:53 ` Applied "spi/bcm63xx-hspi: Enable the clock before calling clk_get_rate()." to the spi tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424161605.GA17825@er01809n.ebgroup.elektrobit.com \
--to=stefan.potyra@elektrobit.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=broonie@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=jonas.gorski@gmail.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sil2review@lists.osadl.org \
--subject='Re: [PATCH v2] spi/bcm63xx-hspi: Enable the clock before calling clk_get_rate().' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).