LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: kbuild-all@01.org, linux-media@vger.kernel.org,
	Luca Ceresoli <luca@lucaceresoli.net>,
	Leon Luo <leonl@leopardimaging.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 09/13] media: imx274: get rid of mode_index
Date: Wed, 25 Apr 2018 01:27:02 +0800	[thread overview]
Message-ID: <201804250108.giRWD6H8%fengguang.wu@intel.com> (raw)
In-Reply-To: <1524558258-530-10-git-send-email-luca@lucaceresoli.net>

[-- Attachment #1: Type: text/plain, Size: 6492 bytes --]

Hi Luca,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on v4.17-rc2 next-20180424]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Luca-Ceresoli/media-imx274-cleanups-improvements-and-SELECTION-API-support/20180424-220137
base:   git://linuxtv.org/media_tree.git master
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:332:0,
                    from include/linux/kernel.h:14,
                    from include/linux/clk.h:16,
                    from drivers/media//i2c/imx274.c:22:
   drivers/media//i2c/imx274.c: In function 'imx274_s_stream':
>> drivers/media//i2c/imx274.c:1027:32: warning: format '%d' expects argument of type 'int', but argument 6 has type 'long int' [-Wformat=]
     dev_dbg(&imx274->client->dev, "%s : %s, mode index = %d\n", __func__,
                                   ^
   drivers/media//i2c/imx274.c:1029:3:
      imx274->mode - &imx274_formats[0]);
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:135:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
   drivers/media//i2c/imx274.c:1027:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(&imx274->client->dev, "%s : %s, mode index = %d\n", __func__,
     ^~~~~~~

vim +1027 drivers/media//i2c/imx274.c

0985dd30 Leon Luo      2017-10-05  1011  
0985dd30 Leon Luo      2017-10-05  1012  /**
0985dd30 Leon Luo      2017-10-05  1013   * imx274_s_stream - It is used to start/stop the streaming.
0985dd30 Leon Luo      2017-10-05  1014   * @sd: V4L2 Sub device
0985dd30 Leon Luo      2017-10-05  1015   * @on: Flag (True / False)
0985dd30 Leon Luo      2017-10-05  1016   *
0985dd30 Leon Luo      2017-10-05  1017   * This function controls the start or stop of streaming for the
0985dd30 Leon Luo      2017-10-05  1018   * imx274 sensor.
0985dd30 Leon Luo      2017-10-05  1019   *
0985dd30 Leon Luo      2017-10-05  1020   * Return: 0 on success, errors otherwise
0985dd30 Leon Luo      2017-10-05  1021   */
0985dd30 Leon Luo      2017-10-05  1022  static int imx274_s_stream(struct v4l2_subdev *sd, int on)
0985dd30 Leon Luo      2017-10-05  1023  {
0985dd30 Leon Luo      2017-10-05  1024  	struct stimx274 *imx274 = to_imx274(sd);
0985dd30 Leon Luo      2017-10-05  1025  	int ret = 0;
0985dd30 Leon Luo      2017-10-05  1026  
0985dd30 Leon Luo      2017-10-05 @1027  	dev_dbg(&imx274->client->dev, "%s : %s, mode index = %d\n", __func__,
f5180bf1 Luca Ceresoli 2018-04-24  1028  		on ? "Stream Start" : "Stream Stop",
f5180bf1 Luca Ceresoli 2018-04-24  1029  		imx274->mode - &imx274_formats[0]);
0985dd30 Leon Luo      2017-10-05  1030  
0985dd30 Leon Luo      2017-10-05  1031  	mutex_lock(&imx274->lock);
0985dd30 Leon Luo      2017-10-05  1032  
0985dd30 Leon Luo      2017-10-05  1033  	if (on) {
0985dd30 Leon Luo      2017-10-05  1034  		/* load mode registers */
da5bbae7 Luca Ceresoli 2018-04-24  1035  		ret = imx274_mode_regs(imx274);
0985dd30 Leon Luo      2017-10-05  1036  		if (ret)
0985dd30 Leon Luo      2017-10-05  1037  			goto fail;
0985dd30 Leon Luo      2017-10-05  1038  
0985dd30 Leon Luo      2017-10-05  1039  		/*
0985dd30 Leon Luo      2017-10-05  1040  		 * update frame rate & expsoure. if the last mode is different,
0985dd30 Leon Luo      2017-10-05  1041  		 * HMAX could be changed. As the result, frame rate & exposure
0985dd30 Leon Luo      2017-10-05  1042  		 * are changed.
0985dd30 Leon Luo      2017-10-05  1043  		 * gain is not affected.
0985dd30 Leon Luo      2017-10-05  1044  		 */
0985dd30 Leon Luo      2017-10-05  1045  		ret = imx274_set_frame_interval(imx274,
0985dd30 Leon Luo      2017-10-05  1046  						imx274->frame_interval);
0985dd30 Leon Luo      2017-10-05  1047  		if (ret)
0985dd30 Leon Luo      2017-10-05  1048  			goto fail;
0985dd30 Leon Luo      2017-10-05  1049  
0985dd30 Leon Luo      2017-10-05  1050  		/* update exposure time */
0985dd30 Leon Luo      2017-10-05  1051  		ret = __v4l2_ctrl_s_ctrl(imx274->ctrls.exposure,
0985dd30 Leon Luo      2017-10-05  1052  					 imx274->ctrls.exposure->val);
0985dd30 Leon Luo      2017-10-05  1053  		if (ret)
0985dd30 Leon Luo      2017-10-05  1054  			goto fail;
0985dd30 Leon Luo      2017-10-05  1055  
0985dd30 Leon Luo      2017-10-05  1056  		/* start stream */
0985dd30 Leon Luo      2017-10-05  1057  		ret = imx274_start_stream(imx274);
0985dd30 Leon Luo      2017-10-05  1058  		if (ret)
0985dd30 Leon Luo      2017-10-05  1059  			goto fail;
0985dd30 Leon Luo      2017-10-05  1060  	} else {
0985dd30 Leon Luo      2017-10-05  1061  		/* stop stream */
cf2a54e2 Luca Ceresoli 2018-04-24  1062  		ret = imx274_write_table(imx274, imx274_stop);
0985dd30 Leon Luo      2017-10-05  1063  		if (ret)
0985dd30 Leon Luo      2017-10-05  1064  			goto fail;
0985dd30 Leon Luo      2017-10-05  1065  	}
0985dd30 Leon Luo      2017-10-05  1066  
0985dd30 Leon Luo      2017-10-05  1067  	mutex_unlock(&imx274->lock);
f5180bf1 Luca Ceresoli 2018-04-24  1068  	dev_dbg(&imx274->client->dev, "%s : Done\n", __func__);
0985dd30 Leon Luo      2017-10-05  1069  	return 0;
0985dd30 Leon Luo      2017-10-05  1070  
0985dd30 Leon Luo      2017-10-05  1071  fail:
0985dd30 Leon Luo      2017-10-05  1072  	mutex_unlock(&imx274->lock);
0985dd30 Leon Luo      2017-10-05  1073  	dev_err(&imx274->client->dev, "s_stream failed\n");
0985dd30 Leon Luo      2017-10-05  1074  	return ret;
0985dd30 Leon Luo      2017-10-05  1075  }
0985dd30 Leon Luo      2017-10-05  1076  

:::::: The code at line 1027 was first introduced by commit
:::::: 0985dd306f727df6c0e71cd8a8eda93e8fa5206e media: imx274: V4l2 driver for Sony imx274 CMOS sensor

:::::: TO: Leon Luo <leonl@leopardimaging.com>
:::::: CC: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53493 bytes --]

  reply	other threads:[~2018-04-24 17:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24  8:24 [PATCH v2 00/13] media: imx274: cleanups, improvements and SELECTION API support Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 01/13] media: imx274: document reset delays more clearly Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 02/13] media: imx274: fix typo in comment Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 03/13] media: imx274: slightly simplify code Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 04/13] media: imx274: remove unused data from struct imx274_frmfmt Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 05/13] media: imx274: rename and reorder register address definitions Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 06/13] media: imx274: remove non-indexed pointers from mode_table Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 07/13] media: imx274: initialize format before v4l2 controls Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 08/13] media: imx274: consolidate per-mode data in imx274_frmfmt Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 09/13] media: imx274: get rid of mode_index Luca Ceresoli
2018-04-24 17:27   ` kbuild test robot [this message]
2018-04-24  8:24 ` [PATCH v2 10/13] media: imx274: actually use IMX274_DEFAULT_MODE Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 11/13] media: imx274: simplify imx274_write_table() Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 12/13] media: imx274: add helper function to fill a reg_8 table chunk Luca Ceresoli
2018-04-24  8:24 ` [PATCH v2 13/13] media: imx274: add SELECTION support for cropping Luca Ceresoli
2018-04-24  9:59   ` Sakari Ailus
2018-04-24 14:30     ` Luca Ceresoli
2018-04-26  8:13       ` Sakari Ailus
2018-04-26 13:43         ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201804250108.giRWD6H8%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=kbuild-all@01.org \
    --cc=leonl@leopardimaging.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=luca@lucaceresoli.net \
    --cc=mchehab@kernel.org \
    --subject='Re: [PATCH v2 09/13] media: imx274: get rid of mode_index' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).