LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH v3 0/2] tty/nozomi: general module cleanup
@ 2018-04-24 22:39 Joey Pabalinas
  2018-04-24 22:39 ` [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro Joey Pabalinas
  2018-04-24 22:39 ` [PATCH v3 2/2] tty/nozomi: fix inconsistent indentation Joey Pabalinas
  0 siblings, 2 replies; 7+ messages in thread
From: Joey Pabalinas @ 2018-04-24 22:39 UTC (permalink / raw)
  To: linux-kernel; +Cc: Greg Kroah-Hartman, Arnd Bergmann, Jiri Slaby

The nozomi module has a few sections which could use a bit of cleanup;
both style and clarity could be improved while maintaining equivalent
semantics.

Cleanup messy portions of the module code while preserving existing
behavior by:

 - Replacing constructs like `len__ > TMP_BUF_MAX ? TMP_BUF_MAX : len__`
   with `min_t(u32, len__, TMP_BUF_MAX)` and function calls like
   snprintf(tbuf, ..., "%s", ...). with strscpy(tbuf, ..., ...).
 - Correct inconsistently indented lines and extraneous whitespace.

CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Arnd Bergmann <arnd@arndb.de>
CC: Jiri Slaby <jslaby@suse.cz>

Joey Pabalinas (2):
  tty/nozomi: cleanup DUMP() macro
  tty/nozomi: fix inconsistent indentation

 drivers/tty/nozomi.c | 100 +++++++++++++++++++++----------------------
 1 file changed, 50 insertions(+), 50 deletions(-)

-- 
2.17.0.rc1.35.g90bbd502d54fe92035.dirty

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-04-25  6:34 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 22:39 [PATCH v3 0/2] tty/nozomi: general module cleanup Joey Pabalinas
2018-04-24 22:39 ` [PATCH v3 1/2] tty/nozomi: cleanup DUMP() macro Joey Pabalinas
2018-04-25  5:38   ` Greg Kroah-Hartman
2018-04-25  5:45     ` Joey Pabalinas
2018-04-25  6:09       ` Greg Kroah-Hartman
2018-04-25  6:34         ` Joey Pabalinas
2018-04-24 22:39 ` [PATCH v3 2/2] tty/nozomi: fix inconsistent indentation Joey Pabalinas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).