From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751247AbeDYHVm (ORCPT ); Wed, 25 Apr 2018 03:21:42 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:34202 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbeDYHVl (ORCPT ); Wed, 25 Apr 2018 03:21:41 -0400 Date: Wed, 25 Apr 2018 00:21:38 -0700 From: Christoph Hellwig To: Arnd Bergmann Cc: Christoph Hellwig , Mauro Carvalho Chehab , Hans Verkuil , Arvind Yadav , mjpeg-users@lists.sourceforge.net, Linux Media Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH] media: zoran: move to dma-mapping interface Message-ID: <20180425072138.GA16375@infradead.org> References: <20180424204158.2764095-1-arnd@arndb.de> <20180425061537.GA23383@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 25, 2018 at 09:08:13AM +0200, Arnd Bergmann wrote: > > That probably also means it can use dma_mmap_coherent instead of the > > handcrafted remap_pfn_range loop and the PageReserved abuse. > > I'd rather not touch that code. How about adding a comment about > the fact that it should use dma_mmap_coherent()? Maybe the real question is if there is anyone that actually cares for this driver, or if we are better off just removing it? Same is true for various other virt_to_bus using drivers, e.g. the grotty atm drivers.